| Summary: | On Windows, craft --package extragear/kdeconnect-kde fails to build NSIS package | ||
|---|---|---|---|
| Product: | [Unmaintained] Craft | Reporter: | nyanpasu64 <nyanpasu64> |
| Component: | Blueprints | Assignee: | Hannah von Reth <vonreth> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde-windows, piyushaggarwal002 |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
Sorry, I pressed Enter before filling out the description.
SUMMARY
STEPS TO REPRODUCE
1. iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/KDE/craft/master/setup/install_craft.ps1'))
2. C:\CraftRoot\craft\craftenv.ps1
3. craft extragear/kdeconnect-kde
4. craft nsis
5. craft --package extragear/kdeconnect-kde
EXPECTED RESULT
NSIS package is created without error.
After posting this bug, I reran `craft --package extragear/kdeconnect-kde` a second time, which succeeded. Maybe this issue only occurs the first time you try building a package, and the build process is not idempotent. Maybe the error is random. (Unfortunately running craft --package takes over 4 minutes because 7z is slow to compress the data.)
KDE Connect works when run from C:\CraftRoot\build\extragear\kdeconnect-kde\archive\bin. C:\CraftRoot\tmp has kdeconnect-kde-master-8a25eb6f-master-windows-msvc2017_64-cl.7z and kdeconnect-kde-master-8a25eb6f-master-windows-msvc2017_64-cl-dbg.7z (only difference is -dbg). I don't see any installers. Running craft --package extragear/kdeconnect-kde again produces the same error as the first time. thanks for reporting the bug, @jimbo1gaz ! The bug is resolved and you can pull the latest changes in 1craft-blueprints-kde` to get the patch. |
SUMMARY STEPS TO REPRODUCE 1. 2. 3. OBSERVED RESULT PS C:\CraftRoot> craft --package extragear/kdeconnect-kde Craft : C:\CraftRoot Version : master ABI : windows-msvc2017_64-cl Download directory : C:\CraftRoot\download ====================================================================================================================================== *** Handling package: extragear/kdeconnect-kde, action: package *** *** Action: package for extragear/kdeconnect-kde *** Overriding C:\CraftRoot\build\extragear\kdeconnect-kde\archive\bin\data\info\dir Overriding C:\CraftRoot\build\extragear\kdeconnect-kde\archive\bin\data\info\dir executing command: C:\CraftRoot\dev-utils\bin\7za.exe a -r C:\CraftRoot\tmp\kdeconnect-kde-master-8a25eb6f-master-windows-msvc2017_64-cl-dbg.7z -bso2 -bsp1 C:\CraftRoot\build\extragear\kdeconnect-kde\archive-dbg\* executing command: C:\CraftRoot\dev-utils\bin\7za.exe a -r C:\CraftRoot\tmp\kdeconnect-kde-master-8a25eb6f-master-windows-msvc2017_64-cl.7z -bso2 -bsp1 C:\CraftRoot\build\extragear\kdeconnect-kde\archive\* *** Craft package succeeded: extragear/kdeconnect-kde after 4 minutes 23 seconds *** Failed to configure C:\CraftRoot\craft\bin\Packager\Nsis\NullsoftInstaller.nsi: @{exename} is not in variables 169: !insertmacro SnoreShortcut "$SMPROGRAMS\KDE Connect.lnk" "$INSTDIR\bin\@{exename}.exe" "@{AppUserModelID}" Traceback (most recent call last): File "C:\CraftRoot\craft\bin\craft.py", line 266, in <module> success = main() File "C:\CraftRoot\craft\bin\craft.py", line 254, in main if not CraftCommands.run(package, action, tempArgs): File "C:\CraftRoot\craft\bin\CraftCommands.py", line 288, in run if not handlePackage(info, action, directTargets=directTargets): File "C:\CraftRoot\craft\bin\CraftCommands.py", line 75, in handlePackage success = doExec(package, action) File "C:\CraftRoot\craft\bin\CraftCommands.py", line 41, in doExec ret = package.instance.runAction(action) File "C:\CraftRoot\craft\bin\Package\PackageBase.py", line 221, in runAction if not getattr(self, step)(): File "C:\CraftRoot\etc\blueprints\locations\craft-blueprints-kde\extragear\kdeconnect-kde\kdeconnect-kde.py", line 74, in createPackage return TypePackager.createPackage(self) File "C:\CraftRoot\craft\bin\Packager\TypePackager.py", line 77, in createPackage return self.__packager.createPackage(self) File "C:\CraftRoot\craft\bin\Packager\NullsoftInstallerPackager.py", line 198, in createPackage if not self.generateNSISInstaller(defines): File "C:\CraftRoot\craft\bin\Packager\NullsoftInstallerPackager.py", line 174, in generateNSISInstaller if not utils.configureFile(self.scriptname, configuredScrip, defines): File "C:\CraftRoot\craft\bin\utils.py", line 804, in configureFile raise Exception(f"Failed to configure {inFile}: @{{{match}}} is not in variables\n" Exception: Failed to configure C:\CraftRoot\craft\bin\Packager\Nsis\NullsoftInstaller.nsi: @{exename} is not in variables 169: !insertmacro SnoreShortcut "$SMPROGRAMS\KDE Connect.lnk" "$INSTDIR\bin\@{exename}.exe" "@{AppUserModelID}" EXPECTED RESULT SOFTWARE/OS VERSIONS Windows: Windows 10 x64 version 1903