Bug 411861

Summary:	Move "Details" tab to the second position in the properties dialog
Product:	[Frameworks and Libraries] frameworks-kio	Reporter:	Lucia Mrenica <lucia.mrenica>
Component:	Properties dialog	Assignee:	KIO Bugs <kio-bugs-null>
Status:	CONFIRMED ---
Severity:	wishlist	CC:	bfeber, elvis.angelaccio, kdelibs-bugs-null, lucia.mrenica, nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Lucia Mrenica 2019-09-12 14:28:36 UTC

SUMMARY
Based on it's content it makes more sense to have it after right after "General". Also if the tabs are supposed to be sorted by most 
used, then it surely shouldn't be at the end.

Comment 1 Björn Feber 2019-09-12 16:16:09 UTC

Do you mean the "View Modes" page?

Comment 2 Lucia Mrenica 2019-09-12 16:38:08 UTC

(In reply to Björn Feber from comment #1)
> Do you mean the "View Modes" page?

Not sure which one do you mean. I mean Right-click -> Properties.

Comment 3 Björn Feber 2019-09-12 16:39:41 UTC

(In reply to mthw0 from comment #2)
> (In reply to Björn Feber from comment #1)
> > Do you mean the "View Modes" page?
> 
> Not sure which one do you mean. I mean Right-click -> Properties.

I thought you were talking about the Dolphin settings.

Comment 4 Lucia Mrenica 2019-09-12 16:44:43 UTC

It's true, I could have written it more clearly. Should I change the title?

Comment 5 Björn Feber 2019-09-12 16:46:07 UTC

(In reply to mthw0 from comment #4)
> It's true, I could have written it more clearly. Should I change the title?

Changed.

Comment 6 Nate Graham 2019-09-12 20:07:28 UTC

I agree, this is more generally useful then the other tabs currently second and third.

This is pretty easy change; just re-arrange the sections here: https://cgit.kde.org/kio.git/tree/src/widgets/kpropertiesdialog.cpp#n567

Would you like to give it a try, mthw0? We'll be happy to help!

https://community.kde.org/Get_Involved/development

Comment 7 Lucia Mrenica 2019-09-13 07:06:32 UTC

(In reply to Nate Graham from comment #6)
> I agree, this is more generally useful then the other tabs currently second
> and third.
> 
> This is pretty easy change; just re-arrange the sections here:
> https://cgit.kde.org/kio.git/tree/src/widgets/kpropertiesdialog.cpp#n567
> 
> Would you like to give it a try, mthw0? We'll be happy to help!
> 
> https://community.kde.org/Get_Involved/development

I have tried changing the order of the if clauses there, but that most likely isn't enough as it didn't change anything.

Comment 8 Lucia Mrenica 2019-09-13 07:27:32 UTC

(In reply to Nate Graham from comment #6)
> I agree, this is more generally useful then the other tabs currently second
> and third.
> 
> This is pretty easy change; just re-arrange the sections here:
> https://cgit.kde.org/kio.git/tree/src/widgets/kpropertiesdialog.cpp#n567
> 
> Would you like to give it a try, mthw0? We'll be happy to help!
> 
> https://community.kde.org/Get_Involved/development

I have also searched the code for any mention of anything named "Details" and I didn't find anything, and that's really weird.

Comment 9 Björn Feber 2019-09-13 07:39:10 UTC

I suggest you join #kde-devel on Matrix or IRC for help. You can find more information here: https://community.kde.org/Get_Involved/development#Communicate_with_the_team

Comment 10 Lucia Mrenica 2019-09-13 07:56:15 UTC

(In reply to Björn Feber from comment #9)
> I suggest you join #kde-devel on Matrix or IRC for help. You can find more
> information here:
> https://community.kde.org/Get_Involved/development#Communicate_with_the_team

OK, I did that.