Summary: | Local selection outline is rendered wrong in some cases | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Tiar <tamtamy.tymona> |
Component: | Tools/Selection | Assignee: | Dmitry Kazakov <dimula73> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dimula73, ghevan, jamesnoeckel, tysontanx |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/graphics/krita/commit/6bc908a39711d20560e314a2bd2a1e198bb14e39 | Version Fixed In: | |
Attachments: | Test .kra file |
Description
Tiar
2019-09-10 18:53:32 UTC
I checked the file attached and painting occurs inside the outlined selection. O also selected the local selection layer and move it using the "move tool" and as expected it now only painted on the new location of the selection. Is there anything special we need to do to trigger this? or maybe it was a glitch no longer reproductible :/ tested in: 4.2.6 and master(b46a3e6d) Ok, I checked the saved file and... well, the outline looks the same as I remember it, but painting now works accordingly. Before saving, I was only able to paint on the bottom of the picture (see the blue brush strokes). Conclusion: it isn't only a visual glitch; it saves wrong to the file, too. Anyway, to reproduce the issue you need to: 1. Make a new layer. 2. Use a rectangle selection on it. 3. Right-click on the layer and select "Add local selection". 4. Go to that selection and use the move tool to move the selection completely out of the range of the selection that was there before. OBSERVED RESULT: Outline doesn't move. Painting occurs in a different place (in the 'new' location of the selection) than the outline suggests. Also after saving, the painting will be available only in the 'old' location of the selection. EXPECTED RESULTS: Painting and outline are consistent. Painting area is also the same after saving and opening the file again. Setting this as confirmed, tested in 4.2.6. Selection outlineis not moved to updated position. Once in this state, outline is locked and updates only after a new selection is made. Local selection and outline move appears to be broken in general. 1. Make selection as local selection 2. Hover selection to make move seelction cursor appear 3. click and drag to move selection. Selection outline will not update but selecting local selection layer shows seletion did move after drag action. I can still reproduce in master Git commit aa0956e545290602a2d8c1cb200e626edef3bc50 by Dmitry Kazakov. Committed on 02/06/2020 at 15:38. Pushed by dkazakov into branch 'krita/4.3'. Fix moving local selection mask created from global selection The problem was caused but a code-duplication bug in KisShapeSelection, which resulted in sigMoveShapes() not being connected anywhere. M +24 -19 libs/ui/flake/kis_shape_selection.cpp M +1 -1 libs/ui/flake/kis_shape_selection.h https://invent.kde.org/graphics/krita/commit/aa0956e545290602a2d8c1cb200e626edef3bc50 Git commit 6bc908a39711d20560e314a2bd2a1e198bb14e39 by Dmitry Kazakov. Committed on 02/06/2020 at 15:38. Pushed by dkazakov into branch 'master'. Fix moving local selection mask created from global selection The problem was caused but a code-duplication bug in KisShapeSelection, which resulted in sigMoveShapes() not being connected anywhere. M +24 -19 libs/ui/flake/kis_shape_selection.cpp M +1 -1 libs/ui/flake/kis_shape_selection.h https://invent.kde.org/graphics/krita/commit/6bc908a39711d20560e314a2bd2a1e198bb14e39 *** Bug 422404 has been marked as a duplicate of this bug. *** *** Bug 411875 has been marked as a duplicate of this bug. *** |