Bug 411735

Summary:	missing icons after compiling
Product:	[Applications] kstars	Reporter:	Ray Wells 4.0 <blues_hawk>
Component:	general	Assignee:	Jasem Mutlaq <mutlaqja>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version First Reported In:	3.3.4
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/kstars/50bd3494188712a9bcd2ceb6362b5f6834bd8f9c	Version Fixed In:	3.3.7
Sentry Crash Report:

Description Ray Wells 4.0 2019-09-09 01:20:23 UTC

SUMMARY
After compiling Kstars and running it I noticed missing icons. Running from a bash terminal showed that "Breeze-dark" was missing. 

STEPS TO REPRODUCE
1. Use a fresh ubuntu system that is not KDE 
2. Compile from git
3. Run Kstars 

OBSERVED RESULT
Menu icons missing

EXPECTED RESULT
Menu icons present

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Peppermint9(ubuntu 18.04 lts)
Qt Version: 5.9.5+dfsg-0ubuntu2.3

ADDITIONAL INFORMATION

I think adding "breeze" to the compile instructions dependency apt command line for ubuntu builds would ensure that the icon set is present after building. 

 It took me a little while to figure it out so I thought I'd mention the fix in case someone else builds in a fresh vm like I did. This is very minor problem and should only take a minute or two to fix. That command line is a nice touch that I wish other devs would include. Dependency hunting can be a real chore.

Comment 1 Jasem Mutlaq 2019-09-15 07:02:33 UTC

Yes I agree. what source did you use to compile? https://techbase.kde.org/Projects/Edu/KStars/Building_KStars_KF5

Comment 2 Ray Wells 4.0 2019-09-15 15:57:58 UTC

I cloned from https://github.com/KDE/kstars.git and I usually look at the INSTALL and READ.me etc. for compile instructions. 

INSTALL in git is where the breeze-icon-theme needs to be added. I tried to edit it and issue a pull but Kstars doesn't allow pulls issued from git(fml), and then I ran out of time before I got the other way figured out. 

  That link is interesting. A similar thing happened to me just the other day with Siril. After I solved deps by hand I suggested an ubuntu command line. Turned out they also had an instruction page I never found. A link to that page at the top of INSTALL might save dorks like myself some trouble getting compiled. 

***Should I clone from git://anongit.kde.org/kstars instead?

thanks, 
Ray

Comment 3 Jasem Mutlaq 2019-09-15 18:03:17 UTC

Git commit 50bd3494188712a9bcd2ceb6362b5f6834bd8f9c by Jasem Mutlaq.
Committed on 15/09/2019 at 18:03.
Pushed by mutlaqja into branch 'master'.

Update INSTALL instructions.
FIXED-IN:3.3.7

M  +4    -3    INSTALL

https://commits.kde.org/kstars/50bd3494188712a9bcd2ceb6362b5f6834bd8f9c