Bug 411704

Summary:	Make clone layers feature more discoverable by adding it to main menu and right-click context menu
Product:	[Applications] krita	Reporter:	Raghavendra kamath <raghu>
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dimula73
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	layers-menu context-menu muyltiple layers

Description Raghavendra kamath 2019-09-08 10:58:59 UTC

SUMMARY
Krita has an excellent feature of cloning layers, It can be accessed via the + icon in the layer stack. And this is the only place to access the clone layer. The clones array option exists but it is not same as creating only one clone layer. I think this place while not wrong is not that much discoverable by user. 

I request adding the option in layer menu and the right click context menu.

In layer menu it can be added below paste layer option.
In the right click context menu of the layer stack it can be added between paste layer and remove layer (this should also work with multiple layer selected as we now have the ability to clone multiple layers). This will make this feature more visible to the user

Comment 1 Dmitry Kazakov 2019-09-09 14:02:06 UTC

Created attachment 122558 [details]
layers-menu

Comment 2 Dmitry Kazakov 2019-09-09 14:02:29 UTC

Created attachment 122559 [details]
context-menu

Comment 3 Dmitry Kazakov 2019-09-09 14:02:48 UTC

Hi, Raghavendra!

Could you please check if the screenshots above look akay?

Comment 4 Raghavendra kamath 2019-09-09 14:12:05 UTC

Hi Dmitry,

The screenshots look okay, I am okay with adding these in the position you have suggested.

Comment 5 Dmitry Kazakov 2019-09-09 14:41:04 UTC

Created attachment 122561 [details]
muyltiple layers

Comment 6 Dmitry Kazakov 2019-09-09 14:51:55 UTC

Git commit d740abcb9fb22ba3a4a3114d7cdc88ea713158cf by Dmitry Kazakov.
Committed on 09/09/2019 at 14:49.
Pushed by dkazakov into branch 'master'.

Add "New->Clone Layer" actions to right-click and menubar menus

M  +1    -0    krita/krita4.xmlgui
M  +6    -0    plugins/dockers/layerdocker/LayerBox.cpp

https://invent.kde.org/kde/krita/commit/d740abcb9fb22ba3a4a3114d7cdc88ea713158cf

Comment 7 Dmitry Kazakov 2019-09-09 14:51:55 UTC

Git commit d568016b0f0be38d9c27b81645710827037baba0 by Dmitry Kazakov.
Committed on 09/09/2019 at 14:48.
Pushed by dkazakov into branch 'master'.

Fix "New Multiple Clone Layers" feature

1) It should not try to copy masks
2) The position of the newly created layers should be at the top of
   the layers stack. Therefore, we should use
   sortAndFilterMergableInternalNodes.
Related: bug 373338

M  +11   -7    libs/ui/kis_layer_manager.cc
M  +1    -1    libs/ui/kis_layer_manager.h
M  +6    -1    libs/ui/kis_node_manager.cpp

https://invent.kde.org/kde/krita/commit/d568016b0f0be38d9c27b81645710827037baba0

Comment 8 Dmitry Kazakov 2019-09-10 08:46:49 UTC

Should be closed now

Comment 9 Dmitry Kazakov 2019-09-13 09:59:56 UTC

Git commit 7f1d7472bda156cbbac5b6c0b89e8dc0582d9759 by Dmitry Kazakov.
Committed on 13/09/2019 at 09:00.
Pushed by dkazakov into branch 'krita/4.2'.

Fix "New Multiple Clone Layers" feature

1) It should not try to copy masks
2) The position of the newly created layers should be at the top of
   the layers stack. Therefore, we should use
   sortAndFilterMergableInternalNodes.
Related: bug 373338

M  +11   -7    libs/ui/kis_layer_manager.cc
M  +1    -1    libs/ui/kis_layer_manager.h
M  +6    -1    libs/ui/kis_node_manager.cpp

https://invent.kde.org/kde/krita/commit/7f1d7472bda156cbbac5b6c0b89e8dc0582d9759