| Summary: | [4.3 prealpha] Crash when using Liquify Transformation | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | acc4commissions |
| Component: | Tools/Transform | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73 |
| Priority: | NOR | ||
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/kde/krita/commit/ce8ed8014a8171a8017541d0e6dd32bc3ae9f88a | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Asserts. | ||
Okay, I can reproduce it here: https://invent.kde.org/snippets/441 Git commit e6e9fea57bc9b57b5b07810e8bcf2b94ec65b954 by Dmitry Kazakov. Committed on 09/09/2019 at 15:28. Pushed by dkazakov into branch 'master'. Fix crash when liquify transform is started too quickly Basically, we shouldn't initiate any transform action until the transform strategy has finished preparing tool initialization (which is flagged by setting m_transform.rootNode()). All user actions happened before the initialization should be ignored (he doesn't have any feedback anyway). M +1 -1 plugins/tools/tool_transform2/kis_tool_transform.cc https://invent.kde.org/kde/krita/commit/e6e9fea57bc9b57b5b07810e8bcf2b94ec65b954 Git commit ce8ed8014a8171a8017541d0e6dd32bc3ae9f88a by Dmitry Kazakov. Committed on 13/09/2019 at 09:00. Pushed by dkazakov into branch 'krita/4.2'. Fix crash when liquify transform is started too quickly Basically, we shouldn't initiate any transform action until the transform strategy has finished preparing tool initialization (which is flagged by setting m_transform.rootNode()). All user actions happened before the initialization should be ignored (he doesn't have any feedback anyway). M +1 -1 plugins/tools/tool_transform2/kis_tool_transform.cc https://invent.kde.org/kde/krita/commit/ce8ed8014a8171a8017541d0e6dd32bc3ae9f88a |
Created attachment 122531 [details] Asserts. SUMMARY git ca902a4 (krita-nightly-x64-v4.3.0-prealpha-336-gca902a4557) Crash when using Liquify Transformation. STEPS TO REPRODUCE 1. Press image with Liquify tool, edit it, then press the enter key to apply. 2. Repeat 1. If you do the recursive process fast enough, couple of assert messages will pop up. 3. If you press 'abort', Krita crashes. SOFTWARE/OS VERSIONS Windows: Win7 macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION kritacrash.log : Error occurred on Sunday, September 8, 2019 at 18:43:28. krita.exe caused a Stack Overflow at location 0000000077727D3F in module ntdll.dll. AddrPC Params