Bug 411607

Summary: Add shadows behind desktop icons
Product: [Plasma] plasmashell Reporter: Lucia Mrenica <lucia.mrenica>
Component: Desktop icons & Folder View widgetAssignee: Eike Hein <hein>
Status: RESOLVED FIXED    
Severity: wishlist CC: lucia.mrenica, nate, plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.16.5   
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://commits.kde.org/plasma-desktop/37469c7dd02dac547c472d757e1c52c9988cced6 Version Fixed/Implemented In: 5.17.0
Sentry Crash Report:

Description Lucia Mrenica 2019-09-05 07:57:17 UTC 
SUMMARY
Labels on desktop icons already have them.
This would make desktop icons blend less into the background.
Comment 1 Nate Graham 2019-09-06 20:50:52 UTC 
Can you provide an example screenshot of where this is a problem such that adding a shadow would fix it?
Comment 2 Lucia Mrenica 2019-09-07 07:22:21 UTC 
(In reply to Nate Graham from comment #1)
> Can you provide an example screenshot of where this is a problem such that
> adding a shadow would fix it?

This would be and extreme case: https://i.imgur.com/gfuAPCh.png
But generally, the text has a shadow, widgets have a shadow and also panel has a shadow, so it would only make sense to also have shadows on icons. It would also make them look like floating above the surface like widgets do.
Comment 3 Nate Graham 2019-09-09 16:11:01 UTC 
Hmm, maybe a subtle one could work. I think the one behind the text would be too strong for icons. I'll play around with it.
Comment 4 Nate Graham 2019-09-09 16:53:24 UTC 
Here's a patch: https://phabricator.kde.org/D23803
Comment 5 Lucia Mrenica 2019-09-09 18:43:09 UTC 
(In reply to Nate Graham from comment #4)
> Here's a patch: https://phabricator.kde.org/D23803

Thanks, that's exactly what I meant.
Comment 6 Nate Graham 2019-09-09 18:45:36 UTC 
Not actually fixed since the patch hasn't yet landed. :)
Comment 7 Nate Graham 2019-09-11 14:56:14 UTC 
Git commit 37469c7dd02dac547c472d757e1c52c9988cced6 by Nate Graham.
Committed on 11/09/2019 at 14:56.
Pushed by ngraham into branch 'master'.

[Folder View] Add subtle shadows to icons

Summary:
Folder View items currently have shadows behind their labels, but not their icons.

This patch adds a very subtle shadow for the icons as well, which improves contrast
for some backgrounds and just looks classy IMO. :)
FIXED-IN: 5.17.0

Test Plan:
Before: {F7334103, size=full}
After: {F7334104, size=full}

Reviewers: hein, #plasma, #vdg, filipf, ndavis

Reviewed By: #vdg, filipf, ndavis

Subscribers: broulik, GB_2, cfeck, ndavis, filipf, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23803

M  +26   -0    containments/desktop/package/contents/ui/FolderItemDelegate.qml

https://commits.kde.org/plasma-desktop/37469c7dd02dac547c472d757e1c52c9988cced6