| Summary: | Color label filter shows the group layer or a parent node if the child should be shown too - even if the group is collapsed, so the child is not visible anyway | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | reptillia39 |
| Component: | Layer Stack | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | REPORTED --- | ||
| Severity: | wishlist | CC: | ghevan, halla, tamtamy.tymona |
| Priority: | NOR | ||
| Version First Reported In: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | Try keeping only No Label. | ||
|
Description
reptillia39
2019-09-02 01:13:16 UTC
From my testing on 7f3ce472e9b118911fe30cfc3c1e8943b505dfd0 (master on September 16th 2019) it looks like the filter works as expected, but the results you get might be because the Layers box always shows the active layer no matter what its color label is. Can you please confirm so we can close the bug report? [Bugzilla *needs* me to add a comment when I change the status to waiting for info... sure, dear bugzilla, I can do that :) ] I tested that it does work properly in latest build. Please close this. Created attachment 122804 [details]
Try keeping only No Label.
The bug is still there it seems. Looks like a group is shown if any of its child layer needs to be shown. A group can be shown empty (if all its layers are filtered), but a layer cannot be shown without a parent... and this behaviour seems to cover also the cases when the parent is collapsed, so you wouldn't see the layer anyway. I saved a new file that only has two group layers, one without a label and one green. The green one is called "O and Original S Filtered Version of Filtered Original Image". I made all layers inside this group green and expanded it. Then I selected the group with no label. The behaviour then depends on the color of the leaf label in the green group. Test: - if I leave it green, then the "No Label" filter filters the green group out. - if I make that layer no-label, then the filter doesn't filter the green group (because the green group is needed to show the no-label layer). - the behaviour is the same if I collapse the group. I could try to make it not dependant on that, but I believe this needs a discussion with some other artists as well. I set it to needs-info since I don't know now if it should be closed or fixed. If you believe this behaviour should be preserved despite you being confused by it before, just close this report as INTENTIONAL, if you have some further arguments against it, please post them here. I would prefer the child layers would be hidden by default unless you have them selected. With the example file I provided, it would enable sharing files in a way that other people can understand how to use the provided image as all the unnecessary info are filtered out. So, for game development, for example, this behavior would be beneficial. For pure painting purpose, for someone that use 100+ layers, this would be a fast way to filter layers if they're using group layers. So, overall, there's more arguments to keep child layers hidden if they're filtered out from my point of view. Thanks for your comment! Automatically switching the status of this bug to REPORTED so that the KDE team knows that the bug is ready to get confirmed. In the future you may also do this yourself when providing needed information. If a layer has to be shown after a filter but belongs to a filtered out group (green group but "no label" child") there has to be a way to show that the shown layer belongs to a group. The easy way is to show the parent of te filtered layer only (no siblings) The parent can also be rendered differently. I think the user has to know the layer belongs to a group. If the "no label" is a child of a label group it has to be shown, otherwise the filtering is inconsistent and we would need a way to adjust the "depth" for the filtering. I do agree with the POV of adding depth option. There's just one more thing to note. Even though the consensus by the majority does not agree with my POV, I should let developers note that you can't actually color label filter masks making those completely impossible to hide via color label filters. EDIT: Not filter mask though you can't easily hide them. Transparency masks on the other hand can't be hidden at all. It is possible to set colors to both transparency and filter masks. If you start by setting a color for a parent layer, it will set it to all the children, which is consistent with group layers behaviour. It is possible to change it in the child too, though. (Marking as wishlist importance (as a wish to add the depth option) and unassigning myself.) |