Bug 411507

Summary: Zoom icon doesn’t update immediately when pressing ‘Ctrl’
Product: [Applications] krita Reporter: Karl Ove Hufthammer <karl>
Component: ToolsAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: minor CC: dimula73, griffinvalley
Priority: NOR    
Version: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/graphics/krita/commit/7b3a9caae920208379f39eef14dc58dd1af832c4 Version Fixed In:
Sentry Crash Report:

Description Karl Ove Hufthammer 2019-09-01 20:02:51 UTC 
SUMMARY
When one uses the zoom tool and inverts the zoom mode using ‘Ctrl’, the zoom icon is only updated to the reflect the new zoom mode when one moves the mouse cursor. It should be updated when one actually changes the zoom mode.


STEPS TO REPRODUCE
1. Open an image.
2. Select the zoom tool.
3. Position the mouse cursor over the image.
4. Press ‘Ctrl’.
5. Move the cursor (while holding ‘Ctrl’ pressed).
6. Hold the cursor still and release ‘Ctrl’.
7. Move the cursor.

OBSERVED RESULT
In step 4, the cursor remains a ‘zoom in’ cursor. It is only changed in step 5.
In step 6, the cursor remains a ‘zoom out’ cursor. It is only changed in step 7.


EXPECTED RESULT
In step 4, the cursor should be changed to the ‘zoom out’ cursor.
In step 6, the cursor should be changed to the ‘zoom in’ cursor.


SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20190829
KDE Plasma Version: 5.16.4
KDE Frameworks Version: 5.61.0
Qt Version: 5.13.0
Kernel Version: 5.2.10-1-default
OS Type: 64-bit
Comment 1 wolthera 2019-09-21 16:17:14 UTC 
Confirmed on KDE Neon with current master.
Comment 2 Dmitry Kazakov 2020-06-19 14:41:11 UTC 
Git commit 651b52340f1a36b1c2d7a7e8e404b50e14d95926 by Dmitry Kazakov.
Committed on 19/06/2020 at 14:40.
Pushed by dkazakov into branch 'krita/4.3'.

Fix handling of Control modifier in the Zoom Tool

We should call base class methods to make sure it baves correctly
(has lastMousePos value in sync)

M  +3    -5    libs/flake/tools/KoZoomTool.cpp

https://invent.kde.org/graphics/krita/commit/651b52340f1a36b1c2d7a7e8e404b50e14d95926
Comment 3 Dmitry Kazakov 2020-06-19 14:41:45 UTC 
Git commit 7b3a9caae920208379f39eef14dc58dd1af832c4 by Dmitry Kazakov.
Committed on 19/06/2020 at 14:41.
Pushed by dkazakov into branch 'master'.

Fix handling of Control modifier in the Zoom Tool

We should call base class methods to make sure it baves correctly
(has lastMousePos value in sync)

M  +3    -5    libs/flake/tools/KoZoomTool.cpp

https://invent.kde.org/graphics/krita/commit/7b3a9caae920208379f39eef14dc58dd1af832c4