Summary: | Stroke Selection Custom Color Not Producing White Color | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | KST <kstgear> |
Component: | Tools/Selection | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | griffinvalley, halla |
Priority: | NOR | ||
Version: | 4.2.5 | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
Latest Commit: | https://invent.kde.org/kde/krita/commit/9c8454f3090013b03306f7281a9110ffe75c5f8a | Version Fixed In: | |
Sentry Crash Report: |
Description
KST
2019-09-01 05:31:02 UTC
I cannot confirm this on master, however, I do agree the window might need a bit of usability polish, it's too easy to pick the wrong options right now. HOWEVER, I am getting a safe assert(that's a pretty dangerous internal error) when using white: SAFE ASSERT (krita): "_pen.color() == Qt::white" in file /home/wolthera/krita/src/libs/image/kis_painter.cc, line 1469 That assert is bogus, I removed it. But I can confirm that if I select white, the selection is stroked with the previously selected color. Git commit 4f2fad4e6b4160b568ed4b3aeef6fd2909d19cd9 by Boudewijn Rempt. Committed on 05/05/2020 at 09:47. Pushed by rempt into branch 'master'. Fix selecting colors in the stroke selection dialog And clean up the code: comparing the translated strings in a combobox with untranslated English strings to figure out what option was chosen is, of course, a big no-no. (cherry picked from commit 9c8454f3090013b03306f7281a9110ffe75c5f8a) M +93 -84 libs/ui/dialogs/kis_dlg_stroke_selection_properties.cpp M +22 -13 libs/ui/dialogs/kis_dlg_stroke_selection_properties.h https://invent.kde.org/kde/krita/commit/4f2fad4e6b4160b568ed4b3aeef6fd2909d19cd9 Git commit 9c8454f3090013b03306f7281a9110ffe75c5f8a by Boudewijn Rempt. Committed on 05/05/2020 at 09:46. Pushed by rempt into branch 'krita/4.3'. Fix selecting colors in the stroke selection dialog And clean up the code: comparing the translated strings in a combobox with untranslated English strings to figure out what option was chosen is, of course, a big no-no. M +93 -84 libs/ui/dialogs/kis_dlg_stroke_selection_properties.cpp M +22 -13 libs/ui/dialogs/kis_dlg_stroke_selection_properties.h https://invent.kde.org/kde/krita/commit/9c8454f3090013b03306f7281a9110ffe75c5f8a |