| Summary: | Dimg test doesn't compile with latest imagemagick | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Siu Chung (Clement) Cheung <clement.cc> |
| Component: | Plugin-DImg-Magick | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | CC: | asturm, caulier.gilles, metzpinguin |
| Priority: | NOR | ||
| Version First Reported In: | 6.2.0 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/kde/digikam/commit/da3d14bcc3b10618c86d39050260dfb6c762a304 | Version Fixed/Implemented In: | 6.3.0 |
| Sentry Crash Report: | |||
Git commit 930161ae62846c22fe5874cd243250ea932d23c9 by Maik Qualmann. Committed on 29/08/2019 at 20:36. Pushed by mqualmann into branch 'master'. disable compiling ImageMagick test modul until version 7.0.9 M +1 -1 core/tests/dimg/CMakeLists.txt M +5 -0 core/tests/dimg/magickloader.cpp https://invent.kde.org/kde/digikam/commit/930161ae62846c22fe5874cd243250ea932d23c9 Git commit da3d14bcc3b10618c86d39050260dfb6c762a304 by Maik Qualmann. Committed on 30/08/2019 at 06:09. Pushed by mqualmann into branch 'master'. do not compile the ImageMagick test module for version 7.0.8 FIXED-IN: 6.3.0 M +2 -1 NEWS M +3 -1 core/tests/dimg/CMakeLists.txt M +3 -3 core/tests/dimg/magickloader.cpp https://invent.kde.org/kde/digikam/commit/da3d14bcc3b10618c86d39050260dfb6c762a304 See also downstream patch: https://bugs.gentoo.org/692326 Git commit 65ed73b01947f936e46bc6042691774072d31b5f by Maik Qualmann. Committed on 30/08/2019 at 10:21. Pushed by mqualmann into branch 'master'. check if defined magick_module M +1 -3 core/tests/dimg/CMakeLists.txt M +3 -3 core/tests/dimg/magickloader.cpp https://invent.kde.org/kde/digikam/commit/65ed73b01947f936e46bc6042691774072d31b5f Thanks Andreas, for the hint. Maik Maik,
Under Mageia6, i seen this compilation error now :
[ 77%] Linking CXX executable showfoto
/mnt/data/GIT/6.x/core/tests/dimg/magickloader.cpp: In function ‘int main(int, char**)’:
/mnt/data/GIT/6.x/core/tests/dimg/magickloader.cpp:145:43: error: ‘const MagickInfo {aka const struct MagickCore::_MagickInfo}’ has no member named ‘module’
QString mod = QLatin1String(inf->module);
^
Installed ImageMagick is standard package version 6.9.10.62
Gilles
Git commit 57803d3a7abc793d3a62460e00abd777e3d13db2 by Gilles Caulier. Committed on 11/09/2019 at 05:37. Pushed by cgilles into branch 'master'. This check can be done with IM version 6.9, at least. This fix broken compilation under Mageia6 using IM 6.9.10.62 M +1 -1 core/tests/dimg/magickloader.cpp https://invent.kde.org/kde/digikam/commit/57803d3a7abc793d3a62460e00abd777e3d13db2 |
SUMMARY Doesn't compile with latest imagemagick STEPS TO REPRODUCE 1. emerge digikam OBSERVED RESULT /var/tmp/portage/media-gfx/digikam-6.2.0/work/digikam-6.2.0/core/tests/dimg/magi ckloader.cpp: In function ‘int main(int, char**)’: /var/tmp/portage/media-gfx/digikam-6.2.0/work/digikam-6.2.0/core/tests/dimg/magi ckloader.cpp:142:45: error: ‘const MagickInfo’ {aka ‘const struct MagickCore::_M agickInfo’} has no member named ‘module’; did you mean ‘_module’? QString module = QLatin1String(inf->module); ^~~~~~ _module EXPECTED RESULT Compiles SOFTWARE/OS VERSIONS Operating System: Gentoo Linux KDE Plasma Version: 5.16.4 KDE Frameworks Version: 5.61.0 Qt Version: 5.12.4 Kernel Version: 4.19.66-gentoo OS Type: 64-bit Processors: 4 × Intel® Core™ i5-2500K CPU @ 3.30GHz Memory: 15.6 GiB of RAM media-gfx/imagemagick-7.0.8.60 ADDITIONAL INFORMATION Caused by this commit: https://github.com/ImageMagick/ImageMagick/commit/3175621ed5442e8f353e0f9db1da5a7bfb07b928 Problem on our side still in latest master: https://invent.kde.org/kde/digikam/blob/master/core/tests/dimg/magickloader.cpp#L142 We could just rename module to magick_module but then it won't compile with older imagemagick. Might need some macro trickery to support both new and old.