Bug 411374

Summary: search on continuous view often mispositions search for non-last column
Product: [Applications] okular Reporter: Dave Gilbert <gilbertd+kde>
Component: generalAssignee: Okular developers <okular-devel>
Status: REPORTED ---    
Severity: wishlist CC: aacid
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: example pdf
result of searching for Bottom of page 1 when previously on page 3

Description Dave Gilbert 2019-08-28 00:25:43 UTC 
SUMMARY
WHen you search for something the page the result is in is scrolled partially to make sure the result is visible; however when you've got multiple pages visible across this often results in you being able to see the bottom of the page with the result text but the start of the next page is off the top.

I find this quite frustrating on huge documents/

STEPS TO REPRODUCE
1. Select continuous with facing pages or overview (for the example I used facing)
2. Search for something near the bottom of a page that will appear in the left column (e.g. in my example start at the bottom of the document and then search for 'bottom of page 1')

OBSERVED RESULT
'bottom of page1' is visible part way up the screen, but the top of page 2 isn't visible because it's scrolled off the top

EXPECTED RESULT
I want to be able to carry on reading from the search point; so I think the rule is:
  a) If the window height allows a full page or more vertically and
  b) The search result is not in the page in the last column

then scroll so that the top of the page with the search result is visible (actually we're interested in the top of the next page but that's getting complex)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Linux Fedora 30 under xfce, okular head
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.4
(xcb windowing)

ADDITIONAL INFORMATION
Comment 1 Dave Gilbert 2019-08-28 00:26:08 UTC 
Created attachment 122395 [details]
example pdf
Comment 2 Dave Gilbert 2019-08-28 00:26:43 UTC 
Created attachment 122396 [details]
result of searching for Bottom of page 1  when previously on page 3
Comment 3 Albert Astals Cid 2019-09-02 20:08:32 UTC 
mispositions is your opinion, i.e. the EXPECTED RESULT is what you'd like to happen, but what we said it'd happen, so i'm turning this into a wishlist.

It may make sense to implement, needs figuring out if it would not cause some other corner cases
Comment 4 Laura David Hurka 2019-09-03 12:43:00 UTC 
I think it makes sense to center the search result, so it is easy to find.

In your case, where you want to continue readind from the search result on, it might make sense to deactivate Continuous. For the problem with “the top of the next page, when in next row”, you might be interested in Bug 196616 or another way of horizontal scrolling.
Comment 5 Dave Gilbert 2019-09-08 00:43:09 UTC 
Albert: Yes, that's fair enough.

David: I'm pretty sure I want continous mode - I've got huge data books and documents, and want to be able to see those 8 pages at a time on my monitor; I think continous is the only sane way. (I run 4 columns, 2 rows)
Centering does make some sense; but it's not what we do now either; I tend to find the search result near the top of the screen with the next page cut off.
When your vertical size is large enough, and you can fit multiple pages on, then perhaps getting the search near the midpoint - but just constraining that you don't lose the top of that row of pages, might make sense.