| Summary: | Editing active color scheme doesn't immediately apply changes | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Michael D <nortexoid> |
| Component: | kcm_colors | Assignee: | Matthew Woehlke <mwoehlke.floss> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | david.cortes.rivera, jpwhiting, kde, kde, nate |
| Priority: | NOR | Keywords: | usability |
| Version: | 5.16.4 | ||
| Target Milestone: | --- | ||
| Platform: | Manjaro | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | KColorSchemeEditor window | ||
|
Description
Michael D
2019-08-26 12:28:10 UTC
Can confirm. This is because when the edited color scheme is the active one, the color editor has no "Save" or "Apply" button, and does not auto-apply any changes made when it's closed. There *is* an "Apply" button for *custom* color themes, but it doesn't work. I mean, there's no Save or Apply button in the editor window itself. Unless I'm confused, it was always like this, but changes were immediately applied after clicking "Apply" within the kcolorscheme editor window, as in the screenshot attached. Created attachment 122376 [details]
KColorSchemeEditor window
That's odd, mine doesn't have the Apply button for any color schemes (built-in, custom, or otherwise). Maybe because I had created a custom scheme long ago it affected the presence of the "Apply" button? *** Bug 441833 has been marked as a duplicate of this bug. *** I see the issue. the "Apply" button in the editor window basically acts like a "Save" button. Once you click it, the state is marked as dirty, so you need to close the window and click the "Apply" button in the main KCM window to actually really truly apply the changes. To make the Apply button (which I am changing to "Save" in https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1034) instantly apply the changes, we need a way for the dialog to communicate with the base KCM. They are in fact separate apps. Right now their only source of communication is that the KCM reads the exit status of the editor app when its window is closed. Probably we would need for the KCM to expose a DBus "Apply right now" method, and then the editor window would call it when clicking the "Save" button. I might look into this if I'm ever in a masochistic mood, as doing anything with DBus always ruins the rest of my day. Overall, this is screaming out for the editor to be integrated into the KCM itself as a sub-page, rather than a separate windowed app. Git commit f4ad2fb1ce9d718c7506bc30fc5d20971de27d14 by Nate Graham. Committed on 01/09/2021 at 22:33. Pushed by ngraham into branch 'master'. kcms/colors: change "Apply" button to "Save" It's a bit odd to have a "Save As..." Button but no "Save" button. The "Apply" Button does the same thing that a save button would, and is active during the same times, so let's just make it *be* a "Save" button. M +2 -1 kcms/colors/editor/scmeditordialog.cpp https://invent.kde.org/plasma/plasma-workspace/commit/f4ad2fb1ce9d718c7506bc30fc5d20971de27d14 Great, thanks! I have to click apply after saving, but then things work as expected. |