Summary: | Dolphin’s sort order chooser human-readable text | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Gabriel Fernandes <gabrielfernnd> |
Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | elvis.angelaccio, nate |
Priority: | NOR | ||
Version: | 19.08.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/dolphin/60d6a3bdbcd44360e1c6ae1c82239ecf6d60ded7 | Version Fixed In: | 19.08.2 |
Description
Gabriel Fernandes
2019-08-23 23:37:14 UTC
Can you attach a screen recording that shows the problem? I'm having a hard time understanding, and the Steps To Reproduce aren't detailed enough (for example, how are you choosing the sorting? What are you clicking on?) Thanks for the video, that's super helpful. Can confirm. Hopefully not too hard to fix. Filed a patch: https://phabricator.kde.org/D23412 great to hear I thought it would land in Dolphin Version 19.08.1 I tried the patch myself, it seems to work Still in patch review, I'm afraid. But it seems to be missing a parenthesis at the end of the for, in the diff. I had added one before the curly at the end in my local build. for (QAction *groupAction : qAsConst(m_sortByActions) ->)<- { Git commit 60d6a3bdbcd44360e1c6ae1c82239ecf6d60ded7 by Nate Graham. Committed on 09/09/2019 at 13:17. Pushed by ngraham into branch 'Applications/19.08'. Fix ascending/descending choosers getting unchecked when re-selecting the same sort order Summary: When you select the same sort order that's already selected, the currently-checked sort order description (the human-readable ascending/descending items) gets unchecked in `slotSortTriggered()` yet the ascending/descending items items only get checked in `slotSortOrderChanged()`. Because the order hasn't gotten changed, neither one gets checked again. This patch fixes the problem by not unchecking them in the first place. FIXED-IN: 19.08.2 Test Plan: 1. Right-click > Sort By > Click the currently-selected sort order 2. Right-click > Sort By > See that the item for the current ascending/descending setting has not been changed Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: broulik, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23412 M +3 -2 src/views/dolphinviewactionhandler.cpp https://commits.kde.org/dolphin/60d6a3bdbcd44360e1c6ae1c82239ecf6d60ded7 |