Summary: | Wrong current version number listed for firmware updates | ||
---|---|---|---|
Product: | [Applications] Discover | Reporter: | Matthew Trescott <matthewtrescott> |
Component: | fwupd Backend | Assignee: | Abhijeet Sharma <sharma.abhijeet2096> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dschridde+kde, leinir, nate |
Priority: | NOR | ||
Version: | 5.16.4 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
See Also: |
https://bugs.kde.org/show_bug.cgi?id=434936 https://bugs.kde.org/show_bug.cgi?id=448521 |
||
Latest Commit: | https://invent.kde.org/plasma/discover/commit/162fedf915d2eddcf10cd2563da5ea33981e57b3 | Version Fixed In: | 5.26 |
Attachments: | Screenshot of incorrect version number |
Description
Matthew Trescott
2019-08-22 18:49:53 UTC
This might be related to bug #448521 or bug #434936, which also deal with wrong version information being displayed. Can confirm. `fwupdmgr get-updates` returns the correct versions: $ fwupdmgr get-updates | grep -i version 6: │ Current version: 0.1.42 7: │ Minimum Version: 0.1.30 21: New version: 0.1.43 33: Lenovo System Firmware Version 1.43 But Discover sees the current version as 0.1.43 for some reason. The code appears to simply not handle this case at all, and sets the installed version string to the same thing as the newly-available version. :/ A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/360 Git commit 162fedf915d2eddcf10cd2563da5ea33981e57b3 by Nate Graham. Committed on 26/08/2022 at 10:10. Pushed by ngraham into branch 'master'. Show correct installed version number for fwupd updates Currently we are simply re-using the version of the available update as the installed version; instead we should set the installed version to be the version of the currently-installed thing. co-authored-by: Aleix Pol i Gonzalez <aleixpol@kde.org> FIXED-IN: 5.25.5 M +7 -0 libdiscover/backends/FwupdBackend/FwupdBackend.cpp M +4 -4 libdiscover/backends/FwupdBackend/FwupdResource.cpp M +6 -1 libdiscover/backends/FwupdBackend/FwupdResource.h https://invent.kde.org/plasma/discover/commit/162fedf915d2eddcf10cd2563da5ea33981e57b3 |