Bug 411013

Summary: export png to google photos or google drive fails
Product: [Applications] digikam Reporter: Philippe ROUBACH <philippe.roubach>
Component: Plugin-WebService-GoogleAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version First Reported In: 6.2.0   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: https://invent.kde.org/kde/digikam/commit/ac22bceda37121fd4815edbcb0a7b74982904019 Version Fixed/Implemented In: 6.3.0
Sentry Crash Report:

Description Philippe ROUBACH 2019-08-17 12:58:17 UTC 
Export portrait png photos to google photos or google drive fails with error message "transfer to google photos fails"

Export landscape png photos to google photos or google drive then only a preview photo is transfered.

Using google photos or google drive import tool works well


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: openSuse Argon 15.1
(available in About System)
KDE Plasma Version: 5.16.4
KDE Frameworks Version: 5.61.0
Qt Version: 5.13.0

ADDITIONAL INFORMATION

kde apps 19.08.0
Comment 1 Maik Qualmann 2019-08-17 13:29:13 UTC 
It is clear that it fails if the image is broken. A NULL image can not be uploaded.

Maik
Comment 2 Maik Qualmann 2019-08-17 14:23:08 UTC 
Git commit 7bed01124efc4e37d18742d056817207d33cd20d by Maik Qualmann.
Committed on 17/08/2019 at 14:21.
Pushed by mqualmann into branch 'master'.

add support for loading broken images to the PNG loader
Related: bug 411011
FIXED-IN: 6.3.0

M  +2    -1    NEWS
M  +55   -9    core/libs/dimg/loaders/pngloader.cpp

https://invent.kde.org/kde/digikam/commit/7bed01124efc4e37d18742d056817207d33cd20d
Comment 3 Philippe ROUBACH 2019-08-17 14:55:18 UTC 
i confirm that exporting good png (portrait or landscape files to google drive exports only a preview compared using google drive import tool.
Comment 4 Philippe ROUBACH 2019-08-17 14:58:43 UTC 
i confirm that exporting good png (portrait or landscape files to google photos exports only a preview compared using google photos import tool
Comment 5 Maik Qualmann 2019-08-17 15:07:56 UTC 
Yes, digiKam uploads the images as JPG files, I assume you want to upload the original file?

Maik
Comment 6 Philippe ROUBACH 2019-08-17 15:22:56 UTC 
(In reply to Maik Qualmann from comment #5)
> Yes, digiKam uploads the images as JPG files, I assume you want to upload
> the original file?
> 
> Maik

I am going to get an optical internet link.
I want to experiment and explore working with png from beginning to end.
Comment 7 Maik Qualmann 2019-08-17 15:38:06 UTC 
Git commit ac22bceda37121fd4815edbcb0a7b74982904019 by Maik Qualmann.
Committed on 17/08/2019 at 15:37.
Pushed by mqualmann into branch 'master'.

add upload original option to GPhoto and GDrive uploader
FIXED-IN: 6.3.0

M  +3    -3    core/dplugins/generic/webservices/google/gdrive/gdtalker.cpp
M  +1    -0    core/dplugins/generic/webservices/google/gdrive/gdtalker.h
M  +2    -1    core/dplugins/generic/webservices/google/gphoto/gptalker.cpp
M  +1    -0    core/dplugins/generic/webservices/google/gphoto/gptalker.h
M  +2    -0    core/dplugins/generic/webservices/google/gswidget.cpp
M  +12   -8    core/dplugins/generic/webservices/google/gswindow.cpp

https://invent.kde.org/kde/digikam/commit/ac22bceda37121fd4815edbcb0a7b74982904019
Comment 8 Philippe ROUBACH 2019-08-17 15:59:26 UTC 
thanks
Comment 9 Maik Qualmann 2019-08-17 16:18:44 UTC 
If you want to work with PNG, note that digiKam uses at least Exiv2-0.27.1. Everything below Exiv-0.27.1 would destroy the color profile in the PNG files when saving metadata.

Maik
Comment 10 caulier.gilles 2019-08-17 16:46:15 UTC 
Maik, 

I propose to set Exiv2 0.27.1 as minimal version for next release.

Gilles