Bug 411011

Summary: digikam does not display a PNG photo
Product: [Applications] digikam Reporter: Philippe ROUBACH <philippe.roubach>
Component: Plugin-DImg-PNGAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: metzpinguin
Priority: NOR    
Version First Reported In: 6.2.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/kde/digikam/commit/7bed01124efc4e37d18742d056817207d33cd20d Version Fixed/Implemented In: 6.3.0
Sentry Crash Report:

Description Philippe ROUBACH 2019-08-17 12:02:23 UTC 
SUMMARY

digikam does not display a PNG photo

STEPS TO REPRODUCE
1. with opencamera I take a PNG photo (portrait mode)
2. with digikam I import this photo
3. 

OBSERVED RESULT

in digikam album photo preview is not displayed
if i click on this photo then photo is not displayed

EXPECTED RESULT

in digikam album photo preview is displayed
if i click on this photo then photo is displayed

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: openSuse Argon 15.1
(available in About System)
KDE Plasma Version: 5.16.4
KDE Frameworks Version: 5.61.0
Qt Version: 5.13.0

ADDITIONAL INFORMATION

kde apps 19.08.0

gwenview, okular display this photo
showphoto does not display this photo
Comment 1 Philippe ROUBACH 2019-08-17 12:20:11 UTC 
no problem to display a PNG photo in landscape mode !
Comment 2 Maik Qualmann 2019-08-17 12:27:57 UTC 
Can you please provide a PNG sample that will not be displayed? If not public, to my email address.

Maik
Comment 3 Philippe ROUBACH 2019-08-17 12:37:35 UTC 
A little problem with the preview thumbnail of a landscape png photo: the preview is a movie preview thumbnail !
Comment 4 Maik Qualmann 2019-08-17 12:51:00 UTC 
I guess you mean with "opencamera" the Android App. I have 2 PNG test images created and imported into digiKam. No problem to reproduce. So a test image is needed.

What exactly, did you take a image or a video?

Maik
Comment 5 Philippe ROUBACH 2019-08-17 13:03:08 UTC 
yes opencamera android app.

I send you a test image.

For all PNG files I took a photo not a video.
Comment 6 Maik Qualmann 2019-08-17 13:22:59 UTC 
The PNG image has clearly not been transmitted correctly and has a "libpng error: IDAT: CRC error". It concerns the last lines of the image. The fact that Gwenview reads it is because it uses the already read image data until the error occurs. We have already implemented this for JPG. I close this bug. You can open a new one with the wish also to read defective PNGs until the error. But the image will always be broken.

Maik
Comment 7 Philippe ROUBACH 2019-08-17 14:16:52 UTC 
ok so this is a kdeconnect transfer problem.

i will try with bluetooth.

thanks
Comment 8 Maik Qualmann 2019-08-17 14:23:08 UTC 
Git commit 7bed01124efc4e37d18742d056817207d33cd20d by Maik Qualmann.
Committed on 17/08/2019 at 14:21.
Pushed by mqualmann into branch 'master'.

add support for loading broken images to the PNG loader
Related: bug 411013
FIXED-IN: 6.3.0

M  +2    -1    NEWS
M  +55   -9    core/libs/dimg/loaders/pngloader.cpp

https://invent.kde.org/kde/digikam/commit/7bed01124efc4e37d18742d056817207d33cd20d
Comment 9 Maik Qualmann 2019-08-17 14:40:42 UTC 
Why do not you just transfer the photos via WLAN? I use the Wifi File Transfer (Pro) APP for that. Select and download in the desktop browser, easy and fast.

Maik
Comment 10 Philippe ROUBACH 2019-08-17 14:48:51 UTC 
(In reply to Maik Qualmann from comment #9)
> Why do not you just transfer the photos via WLAN? I use the Wifi File
> Transfer (Pro) APP for that. Select and download in the desktop browser,
> easy and fast.
> 
> Maik

no corrupt photos via bluetooth (yes it is slow).

i will try wifi file transfer app.

it would be a good thing to get in digikam a checking to detect corrupt file and warning user when adding a photo in an album by any way (digikam import or dolphin copy-past to an album then launching digikam)

thanks