Bug 410923

Summary: Lack of frame in "Screen Locking"'s Settings
Product: [Plasma] kscreenlocker Reporter: tgnff242
Component: kcmAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: bhush94, kde, nate
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=394296
Latest Commit: https://commits.kde.org/kscreenlocker/82f198916da1884c0da60ea0e08026d11a12142f Version Fixed In: 5.17.0
Sentry Crash Report:

Description tgnff242 2019-08-15 10:09:29 UTC 
STEPS TO REPRODUCE
Go to System Settings > Desktop Behavior > Screen Locking


OBSERVED RESULT
Unlike other settings, like System Settings > Window Management > Window Behavior, there's no frame that encloses the contents of the tab.


SOFTWARE VERSIONS
KDE Plasma Version: 5.16.4
KDE Frameworks Version: 5.60
Qt Version: 5.13.0
Comment 1 Nate Graham 2019-08-15 13:05:11 UTC 
Root caused is the lack of Bug 394296.

I suppose we could make another fake one like we do for the Window Decorations and Plasma-pa KCMs. :/
Comment 2 Kai Uwe Broulik 2019-08-15 14:02:16 UTC 
That KCM is QtWidgets, it is explicitly set to document mode. I think because on the other tab it embeds QML and then you would get a frame around a frame.
Comment 3 Nate Graham 2019-08-15 14:07:35 UTC 
The QML Appearance tab doesn't have its own frame, though. So I think that would be fine.
Comment 4 Nate Graham 2019-08-15 16:12:00 UTC 
Git commit 82f198916da1884c0da60ea0e08026d11a12142f by Nate Graham.
Committed on 15/08/2019 at 16:11.
Pushed by ngraham into branch 'master'.

[KCM] Draw full QTabWidget frame

Summary:
Right now we're not drawing the full frame in the Screen Locking KCM to work around
https://bugs.kde.org/show_bug.cgi?id=410943. But this only exchanges one aesthetic
problem for another, and as such, is not an appropriate workaround.

This patch draws the full frame to fix the bug listed below,  and then we can concentrate
on fixing https://bugs.kde.org/show_bug.cgi?id=410943 so it works for everyone with
no hacks or workarounds required.
FIXED-IN: 5.17.0

Test Plan:
{F7248765}
{F7248766}

Reviewers: #vdg, #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23184

M  +0    -3    kcm/kcm.ui

https://commits.kde.org/kscreenlocker/82f198916da1884c0da60ea0e08026d11a12142f