Bug 410870

Summary: 'amarok -l <somefile>' crashes
Product: [Applications] amarok Reporter: Christophe Marin <christophe>
Component: generalAssignee: Amarok Developers <amarok-bugs-dist>
Status: RESOLVED FIXED    
Severity: crash    
Priority: NOR    
Version: kf5   
Target Milestone: kf5   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/amarok/457fbda25a85a102bfda92aa7137e7ef5e4c8b00 Version Fixed In:
Sentry Crash Report:

Description Christophe Marin 2019-08-13 10:13:09 UTC 
Using master,

amarok -a <some file> asserts

Log:
12:12:04 - amarok(1019) - org.kde.kcrash: KCrash::initialize: KCrash disabled through environment.
12:12:04 - amarok(1019) - org.kde.kcrash: KCrash::initialize: KCrash disabled through environment.
12:12:04 - amarok(1019) -  : QObject::connect(Playlist::Model, Playlist::ProxyBase): invalid null parameter
12:12:04 - amarok(1019) -  : QObject::connect(Playlist::Model, Playlist::ProxyBase): invalid null parameter
12:12:04 - amarok(1019) -  : QObject::connect(Playlist::Model, Playlist::ProxyBase): invalid null parameter
12:12:04 - amarok(1019) -  : QObject::connect(Playlist::Model, Playlist::ProxyBase): invalid null parameter
12:12:04 - amarok(1019) -  : you need to call AmarokConfig::instance before using ← This is the assert from the generated amarokconfig.cpp

Backtrace:

#2  0x00007f4386b1aa59 in qt_message_fatal (context=..., message=<synthetic pointer>...) at global/qlogging.cpp:1904
#3  QMessageLogger::fatal (this=<optimized out>, msg=<optimized out>) at global/qlogging.cpp:888
#4  0x00007f438873977c in AmarokConfig::self () at amarokconfig.cpp:24
#5  0x00007f4388295629 in AmarokConfig::startPlayingOnAdd () at amarokconfig.h:1002
#6  0x00007f4388293684 in Playlist::Controller::insertOptioned (this=0xc35ee0, urls=..., options=...) at /data/kde/src/amarok/src/playlist/PlaylistController.cpp:262
#7  0x00007f43885dc4ca in App::handleCliArgs (this=0x7ffc1c80e670, cwd=...) at /data/kde/src/amarok/src/App.cpp:303
#8  0x00007f43885df314 in App::newInstance (this=0x7ffc1c80e670) at /data/kde/src/amarok/src/App.cpp:639
#9  0x00007f43885dde0c in App::continueInit (this=0x7ffc1c80e670) at /data/kde/src/amarok/src/App.cpp:446
#10 0x000000000040c383 in main (argc=3, argv=0x7ffc1c80e7c8) at /data/kde/src/amarok/src/main.cpp:395
Comment 1 Christophe Marin 2019-08-13 23:43:06 UTC 
Sorry, the command is:
 
amarok -l <some file>

amarok -a works as expected.
Comment 2 Christophe Marin 2019-08-24 07:05:03 UTC 
Git commit 457fbda25a85a102bfda92aa7137e7ef5e4c8b00 by Christophe Giboudeaux.
Committed on 24/08/2019 at 07:04.
Pushed by cgiboudeaux into branch 'master'.

Fix a crash when running 'amarok -l /path/to/file'

Summary: BUG: 410870

Test Plan:
amarok -l <somefile>

Before: Assert "you need to call AmarokConfig::instance before using"

After: the file is queued and played.

Reviewers: heikobecker

Reviewed By: heikobecker

Subscribers: #amarok, amarok-devel

Differential Revision: https://phabricator.kde.org/D23326

M  +1    -2    src/App.cpp

https://commits.kde.org/amarok/457fbda25a85a102bfda92aa7137e7ef5e4c8b00