Bug 410805

Summary:	Use cmake --build and cmake --install instead of calling make directly
Product:	[Developer tools] kdesrc-build	Reporter:	Frederik Gladhorn <gladhorn>
Component:	general	Assignee:	Michael Pyne <mpyne>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ashark, Harmandhadli97, nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Frederik Gladhorn 2019-08-11 09:41:42 UTC

SUMMARY
It is these days possible to delegate building and installing to cmake.
That allows switching to Ninja in a very easy fashion.

 cmake-options -GNinja

If the default make command would be: cmake --build
And the default install cmake --install

EXPECTED RESULT

Switching CMake to use Ninja should just work.

Comment 1 Andrew Shark 2024-05-07 08:02:43 UTC

Currently, Ninja generator is already supported. Use cmake-generator Ninja config option.

In the output you can see:

         Running cmake targeting Ninja...
run_logged_command(): Module extra-cmake-modules, Command: cmake -B . -S /home/andrew/kde6/src/extra-cmake-modules -G Ninja -D...

        Compiling...
run_logged_command(): Module extra-cmake-modules, Command: ninja -j 10

        Installing extra-cmake-modules
run_logged_command(): Module extra-cmake-modules, Command: ninja install

Comment 2 Nate Graham 2024-05-07 16:08:37 UTC

Please don't close bug reports for kdesrc-build just because the feature is in kde-builder. This is the kdesrc-build bug tracker, not the kde-builder bug tracker.

Until kdesrc-build is formally archived, its bug reports should stay open.

Comment 3 Nate Graham 2024-05-07 16:09:35 UTC

But also, isn't Ninja already supported in kdesrc-build too? Looks like it is. Re-closing! 😅