| Summary: | Regular crashes | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | adam |
| Component: | General | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | adam, dimula73, griffinvalley, halla, manuel.snudl.zeidler |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | 4.2.5 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/kde/krita/commit/6416c56796e1af5d619e06dc99a2ec91a67ccb0a | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | krita.log | ||
|
Description
adam
2019-08-10 00:38:53 UTC
Arch is always kind of a difficult system. I cannot reproduce the issue, and the crash itself seems to happen inside Qt. If you cannot reproduce it on another system, then I do suspect it's an issue with the system, and not a bug in Krita. If you can consistently reproduce, please: * install the debug symbols for Krita and Qt so the backtrace is more useful * append the ~/.local/share/krita.log file as an attachment to this bug report. Created attachment 122107 [details]
krita.log
Comment on attachment 122107 [details]
krita.log
This is consistent for the error between the two Arch systems I tested on. I also set up a KDE Neon system to test but was not able to reproduce the issue there.
Thanks for your comment! Automatically switching the status of this bug to REPORTED so that the KDE team knows that the bug is ready to get confirmed. In the future you may also do this yourself when providing needed information. Offending line seems to be "13 Aug 2019 20:22:52 -0500: ASSERT (krita): "m_buffer[currentIndex].loadAcquire() > 0" in file /build/krita/src/krita-4.2.5/libs/image/tiles3/KisTiledExtentManager.cpp, line 87" which is here: https://invent.kde.org/kde/krita/blob/master/libs/image/tiles3/KisTiledExtentManager.cpp#L87 Given that this particular assert "Does nothing in case of a failure. Just continues execution.", I suspect the arch package is build with debug on(as in, a developer build) which might make a big difference in reproducability. I still can't seem to reproduce this on KDE Neon, despite having a debug+asan build... Maybe qt 5.13 is to blame??? ------------------------ Krita Version: 4.3.0-prealpha (git 709ac34) Languages: en_US, en_GB, nl Hidpi: true Qt Version (compiled): 5.12.3 Version (loaded): 5.12.3 OS Information Build ABI: x86_64-little_endian-lp64 Build CPU: x86_64 CPU: x86_64 Kernel Type: linux Kernel Version: 4.15.0-55-generic Pretty Productname: KDE neon User Edition 5.16 Product Type: neon Product Version: 18.04 Hardware Information GPU Acceleration: auto Memory: 7725 Mb Number of Cores: 8 Swap Location: /tmp It might also be related that the reported tests 4.2 build. Master-branch has a few fixed in the tile data manager (which are "not related" though) Hi, Adam! Does that .tiff image that you are importing have any private data? If not, could you share it with me? (you can send it to my email, if it is not-for-sharing: dimula73 at gmail dot com). If you cannot share if, could you tell the exact size of the image, its color model and the number of layers? I'll mark the bug as waiting-for-info for now. Greetings Dmitry, The file is a bit too large to attach (4.1MB), here it is in Dropbox if that is alright: https://www.dropbox.com/s/7v3unu7cyh8h5al/MDS00048.tiff?dl=0 If it helps here is a brief video where I go back through my steps: https://youtu.be/plZN16_3md4 I click the draw area once while the colorspace is being converted. If I click while it is converting to CMYK I can make it crash immediately 19/20 times, the 1/20 it will crash later while I'm using the brush tool or converting the image space back to RGB. If I don't click it is maybe 50/50 making through the color conversion. Original file is 1 layer. Krita doesn't crash if I don't duplicate the layer. exiftool: ExifTool Version Number : 11.50 File Name : MDS00048.tiff Directory : . File Size : 3.9 MB File Modification Date/Time : 2019:08:07 19:03:55-05:00 File Access Date/Time : 2019:09:10 19:24:44-05:00 File Inode Change Date/Time : 2019:08:07 19:15:32-05:00 File Permissions : rwxr-xr-x File Type : TIFF File Type Extension : tif MIME Type : image/tiff Exif Byte Order : Little-endian (Intel, II) Subfile Type : Full-resolution Image Image Width : 3309 Image Height : 4937 Bits Per Sample : 8 8 8 Compression : JPEG Photometric Interpretation : RGB Strip Offsets : (Binary data 4705 bytes, use -b option to extract) Orientation : Horizontal (normal) Samples Per Pixel : 3 Rows Per Strip : 8 Strip Byte Counts : (Binary data 3128 bytes, use -b option to extract) X Resolution : 300 Y Resolution : 300 Planar Configuration : Chunky Resolution Unit : inches JPEG Tables : (Binary data 289 bytes, use -b option to extract) Image Size : 3309x4937 Megapixels : 16.3 I have been able to reproduce this on multiple Arch systems in 4.2.5, 4.2.6, and the 4.3.0 pre-alpha using various files and file types (TIFF, PNG, and JPG). The logs always end the same. I don't see this issue on other distro's, but I haven't tried updating Qt to 5.13 on those systems yet. Krita doesn't want to launch if I downgrade all the Qt packages to 5.12.x on Arch- a bit of a bear for me on what I'm missing there so I've been temporarily using a KDE Neon system for strictly Krita. Hi, Adam! Thank you for the testing image and video! With this image I can really reproduce the crash. *** Bug 406250 has been marked as a duplicate of this bug. *** Git commit a9b8a3a1fa2beca232710a37b4cf9dc6284a4ff8 by Dmitry Kazakov. Committed on 11/09/2019 at 17:14. Pushed by dkazakov into branch 'kazakov/convert-image-color-space-in-strokes'. Fix random crashes when converting image color space The patch basically ports image color space conversion into strokes system. The crash happened becasue updates were initiated right when the visitor was changing layers. With the strokes, this problem should be resolved. The patch also changed UIX: now 'Image->Properties->Color Space' changes the entire color space of the image, but not only color space of the root node (projection). M +1 -1 libs/image/CMakeLists.txt D +0 -155 libs/image/kis_colorspace_convert_visitor.cpp D +0 -94 libs/image/kis_colorspace_convert_visitor.h M +53 -26 libs/image/kis_image.cc M +6 -6 libs/image/kis_image.h M +0 -1 libs/image/kis_paint_device.cc M +3 -1 libs/image/kis_transform_mask.cpp M +3 -1 libs/image/lazybrush/kis_colorize_mask.cpp A +105 -0 libs/image/processing/kis_convert_color_space_processing_visitor.cpp [License: GPL (v2+)] A +54 -0 libs/image/processing/kis_convert_color_space_processing_visitor.h [License: GPL (v2+)] M +0 -1 libs/image/tests/CMakeLists.txt D +0 -46 libs/image/tests/kis_colorspace_convert_visitor_test.cpp D +0 -33 libs/image/tests/kis_colorspace_convert_visitor_test.h M +1 -2 libs/image/tests/kis_image_test.cpp M +1 -3 libs/libkis/Document.cpp M +3 -4 libs/libkis/Node.cpp M +3 -1 libs/ui/kis_image_manager.cc M +1 -13 plugins/extensions/colorspaceconversion/colorspaceconversion.cc M +1 -0 plugins/impex/psd/psd_saver.cpp M +2 -1 sdk/tests/filestest.h https://invent.kde.org/kde/krita/commit/a9b8a3a1fa2beca232710a37b4cf9dc6284a4ff8 Git commit ccf5657ac87a92bef01aa69915e230ef7fec17db by Dmitry Kazakov. Committed on 05/11/2019 at 17:44. Pushed by dkazakov into branch 'master'. Fix random crashes when converting image color space The patch basically ports image color space conversion into strokes system. The crash happened becasue updates were initiated right when the visitor was changing layers. With the strokes, this problem should be resolved. The patch also changed UIX: now 'Image->Properties->Color Space' changes the entire color space of the image, but not only color space of the root node (projection). M +1 -1 libs/image/CMakeLists.txt D +0 -155 libs/image/kis_colorspace_convert_visitor.cpp D +0 -94 libs/image/kis_colorspace_convert_visitor.h M +53 -26 libs/image/kis_image.cc M +6 -6 libs/image/kis_image.h M +0 -1 libs/image/kis_paint_device.cc M +3 -1 libs/image/kis_transform_mask.cpp M +3 -1 libs/image/lazybrush/kis_colorize_mask.cpp A +105 -0 libs/image/processing/kis_convert_color_space_processing_visitor.cpp [License: GPL (v2+)] A +54 -0 libs/image/processing/kis_convert_color_space_processing_visitor.h [License: GPL (v2+)] M +0 -1 libs/image/tests/CMakeLists.txt D +0 -46 libs/image/tests/kis_colorspace_convert_visitor_test.cpp D +0 -33 libs/image/tests/kis_colorspace_convert_visitor_test.h M +1 -2 libs/image/tests/kis_image_test.cpp M +1 -3 libs/libkis/Document.cpp M +3 -4 libs/libkis/Node.cpp M +3 -1 libs/ui/kis_image_manager.cc M +1 -13 plugins/extensions/colorspaceconversion/colorspaceconversion.cc M +1 -0 plugins/impex/psd/psd_saver.cpp M +2 -1 sdk/tests/filestest.h https://invent.kde.org/kde/krita/commit/ccf5657ac87a92bef01aa69915e230ef7fec17db Git commit 6416c56796e1af5d619e06dc99a2ec91a67ccb0a by Dmitry Kazakov. Committed on 05/11/2019 at 17:44. Pushed by dkazakov into branch 'krita/4.2'. Fix random crashes when converting image color space The patch basically ports image color space conversion into strokes system. The crash happened becasue updates were initiated right when the visitor was changing layers. With the strokes, this problem should be resolved. The patch also changed UIX: now 'Image->Properties->Color Space' changes the entire color space of the image, but not only color space of the root node (projection). M +1 -1 libs/image/CMakeLists.txt D +0 -155 libs/image/kis_colorspace_convert_visitor.cpp D +0 -94 libs/image/kis_colorspace_convert_visitor.h M +53 -26 libs/image/kis_image.cc M +6 -6 libs/image/kis_image.h M +0 -1 libs/image/kis_paint_device.cc M +3 -1 libs/image/kis_transform_mask.cpp M +3 -1 libs/image/lazybrush/kis_colorize_mask.cpp A +105 -0 libs/image/processing/kis_convert_color_space_processing_visitor.cpp [License: GPL (v2+)] A +54 -0 libs/image/processing/kis_convert_color_space_processing_visitor.h [License: GPL (v2+)] M +0 -1 libs/image/tests/CMakeLists.txt D +0 -46 libs/image/tests/kis_colorspace_convert_visitor_test.cpp D +0 -33 libs/image/tests/kis_colorspace_convert_visitor_test.h M +1 -2 libs/image/tests/kis_image_test.cpp M +1 -3 libs/libkis/Document.cpp M +3 -4 libs/libkis/Node.cpp M +3 -1 libs/ui/kis_image_manager.cc M +1 -13 plugins/extensions/colorspaceconversion/colorspaceconversion.cc M +1 -0 plugins/impex/psd/psd_saver.cpp M +2 -1 sdk/tests/filestest.h https://invent.kde.org/kde/krita/commit/6416c56796e1af5d619e06dc99a2ec91a67ccb0a |