Bug 410689

Summary: [Regression] Ctrl+Shift+Left/Right doesn't move tabs
Product: [Applications] konsole Reporter: Konstantin Kharlamov <Hi-Angel>
Component: tabbarAssignee: Konsole Developer <konsole-devel>
Status: RESOLVED NOT A BUG    
Severity: normal CC: justin.zobel, kdebugs, nate, wbauer1
Priority: NOR    
Version: master   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: attachment-3028-0.html

Description Konstantin Kharlamov 2019-08-07 09:40:52 UTC
SUMMARY

After multiple Konsole tabs are opened, pressing Ctrl+Shift+<arrow> doesn't move them around. Last known it worked with is 19.04.03

STEPS TO REPRODUCE
1. Build latest master (tested with commit ac9ccc94)
2. Open the built konsole, and press Ctrl+Shift+t to make second tab to open. 
3. Press Ctrl+Shift+Left

OBSERVED RESULT

Nothing happens.

EXPECTED RESULT

In the tabs panel at the bottom the focused tab gets moved left. 

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Archlinux, repro both in Plasma 5.16 and pure i3wm
KDE Plasma Version: 5.16
KDE Frameworks Version: 5.60.0
Qt Version: 5.13.0
Comment 1 Kurt Hindenburg 2019-08-08 02:04:44 UTC
This was fixed in 68ea9bf6cc118118e824a661013b4f3438a7728e around Jun 26 so your version should have it.


I have Ctrl+Alt+arrow - have you changed the shortcut?
Comment 2 Konstantin Kharlamov 2019-08-08 06:47:14 UTC
(In reply to Kurt Hindenburg from comment #1)
> This was fixed in 68ea9bf6cc118118e824a661013b4f3438a7728e around Jun 26 so
> your version should have it.
> 
> 
> I have Ctrl+Alt+arrow

Hmm, this one works.

> have you changed the shortcut?

I don't remember doing so, AFAIK it's default hotkey.

Either way, when I go to "Setings → Configure Shortcuts", I see "Ctrl+Shift+Left" is set to "Focus Left Terminal". This works in Konsole from my distro repository (19.04.03), but it doesn't in the one built from master when I run it from the build directory.
Comment 3 Wolfgang Bauer 2019-08-09 11:55:27 UTC
(In reply to Konstantin Kharlamov from comment #2)
> (In reply to Kurt Hindenburg from comment #1)
> > This was fixed in 68ea9bf6cc118118e824a661013b4f3438a7728e around Jun 26 so
> > your version should have it.
> > 
> > 
> > I have Ctrl+Alt+arrow
> 
> Hmm, this one works.
> 
> > have you changed the shortcut?
> 
> I don't remember doing so, AFAIK it's default hotkey.
The default shortcuts for moving tabs have been changed to Ctrl+Alt+qrrow in 
https://cgit.kde.org/konsole.git/commit/?id=c53e8cb17e116727569cff2e287906411b832970

> Either way, when I go to "Setings → Configure Shortcuts", I see
> "Ctrl+Shift+Left" is set to "Focus Left Terminal". This works in Konsole
> from my distro repository (19.04.03), but it doesn't in the one built from
> master when I run it from the build directory.
"Focus Left Lerminal" only has effect if you split the view, it moves focus to the left view.
And that works fine here. (with konsole 19.07.90)

But apparently Ctrl+Shift+Right ("Focus Right Terminal") doesn't have any effect...
Comment 4 Konstantin Kharlamov 2019-08-09 12:10:43 UTC
(In reply to Wolfgang Bauer from comment #3)
> (In reply to Konstantin Kharlamov from comment #2)
> > (In reply to Kurt Hindenburg from comment #1)
> > > This was fixed in 68ea9bf6cc118118e824a661013b4f3438a7728e around Jun 26 so
> > > your version should have it.
> > > 
> > > 
> > > I have Ctrl+Alt+arrow
> > 
> > Hmm, this one works.
> > 
> > > have you changed the shortcut?
> > 
> > I don't remember doing so, AFAIK it's default hotkey.
> The default shortcuts for moving tabs have been changed to Ctrl+Alt+qrrow in 
> https://cgit.kde.org/konsole.git/commit/
> ?id=c53e8cb17e116727569cff2e287906411b832970
> 
> > Either way, when I go to "Setings → Configure Shortcuts", I see
> > "Ctrl+Shift+Left" is set to "Focus Left Terminal". This works in Konsole
> > from my distro repository (19.04.03), but it doesn't in the one built from
> > master when I run it from the build directory.
> "Focus Left Lerminal" only has effect if you split the view, it moves focus
> to the left view.
> And that works fine here. (with konsole 19.07.90)
> 
> But apparently Ctrl+Shift+Right ("Focus Right Terminal") doesn't have any
> effect...

Oh, I see, so, on master behavior of the "Focus Left Terminal" have been changed from moving tabs to focusing splits. And to access prev. functional you have to use "Move tab to the left".

This makes sense. However I wonder if it would also be useful to rebind the default Ctrl+Shift+Left to "Move tab to the left"? This would retain the old behavior from user stand-point, while allowing them to access the new functional.
Comment 5 Wolfgang Bauer 2019-08-09 12:48:48 UTC
(In reply to Konstantin Kharlamov from comment #4)
> Oh, I see, so, on master behavior of the "Focus Left Terminal" have been
> changed from moving tabs to focusing splits. And to access prev. functional
> you have to use "Move tab to the left".
No, the behavior has not changed, only the default keyboard shortcuts.
I.e. Ctrl+Shift+Left was "Move tab to the left" before, and now is "Focus Left Terminal" (while the default shortcut for "Move tab to the left" is Ctrl+Alt+Left now).

I don't know why this has been changed though. Maybe it would have been better to keep Ctrl+Shift+Arrow for the "Move tab to..." actions and use Ctrl+Alt+Arrow for the new "Focus XXX terminal" actions, to not surprise users.
Comment 6 Wolfgang Bauer 2019-08-09 12:58:15 UTC
PS: If "Focus Left Terminal" did indeed move the tab in 19.04.3 (if it existed already), it was a bug I'd say...
I don't have a 19.04.3 at the moment to try though (only 4.x, which only has "Move Tab Left" bound to Ctrl+Shift+Left, and no "Focus Left Terminal" at all).
Comment 7 Justin Zobel 2020-11-05 08:08:13 UTC
Ctrl Alt Left/Right seems to be the default now.
Comment 8 Wolfgang Bauer 2020-11-05 11:08:12 UTC
(In reply to Justin Zobel from comment #7)
> Ctrl Alt Left/Right seems to be the default now.
Yes, they are the default for Focus Left/Right Terminal now.

But they were the default for Move Tab Left/Right before, i.e. Ctrl+Alt+Left/Right did move tabs in older versions (up to 19.04.3), hence this "regression" report.

Personally I don't mind, so I won't reopen it myself though.
Comment 9 Wolfgang Bauer 2020-11-05 11:11:29 UTC
(In reply to Wolfgang Bauer from comment #8)
> (In reply to Justin Zobel from comment #7)
> > Ctrl Alt Left/Right seems to be the default now.
> Yes, they are the default for Focus Left/Right Terminal now.
> 
> But they were the default for Move Tab Left/Right before, i.e.
> Ctrl+Alt+Left/Right did move tabs in older versions (up to 19.04.3), hence
> this "regression" report.
Erm sorry. I confused Alt with Shift....

Read this as:
Yes, Ctrl+Alt+Left/Right is the default for Move Tab Left/Right now (since 19.08).

But Ctrl+Shift+Left/Right was the default for Move Tab Left/Right before (upto 19.04.3), hence this "regression" report.
Comment 10 Konstantin Kharlamov 2020-11-05 11:15:36 UTC
Well, in case anybody is interested in the OP's opinion: I think since this has been unresolved for me than a year, making another breaking change back will upset yet another part of the users, who already got used to the new behavior. Such bug is something that needs to be fixed as fast as possible, otherwise whichever change you'll do, someone is gonna be unhappy.

I personally have explicitly bound the older shortcuts.
Comment 11 tcanabrava 2022-06-18 13:28:14 UTC
Created attachment 149895 [details]
attachment-3028-0.html

Not a regression, this changed to focus different splits.

On Sat, 18 Jun 2022 at 13:43 Martin <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=410689
>
> Martin <kdebugs@signup.servebeer.com> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |
> kdebugs@signup.servebeer.co
>                    |                            |m
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.