| Summary: | Disabling "Enable menu accelerators" makes Konsole ignore keys | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Konstantin Kharlamov <Hi-Angel> |
| Component: | keyboard | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version: | 19.04.3 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/konsole/f8f7b43936b7b3718383d3a3ca67a387e28a3089 | Version Fixed In: | 19.08 |
| Sentry Crash Report: | |||
| Attachments: | Fix for menu accelerators | ||
|
Description
Konstantin Kharlamov
2019-08-06 08:43:17 UTC
I figured it should be an easy fix, so I downloaded the code, and tried searching it. And… search for `AllowMenuAccelerators` shows that all that konsole does is creates the checkbox and a configuration setting. This is odd, it does not use the setting anywhere. Setting the checkbox shouldn't do anything, the checkbox is unused, I'm clueless why it even works. (In reply to Konstantin Kharlamov from comment #1) > I figured it should be an easy fix, so I downloaded the code, and tried > searching it. And… search for `AllowMenuAccelerators` shows that all that > konsole does is creates the checkbox and a configuration setting. This is > odd, it does not use the setting anywhere. > > Setting the checkbox shouldn't do anything, the checkbox is unused, I'm > clueless why it even works. Aha, nvm, I missed the usage in header file, where it declared a getter starting with low-case "a", "allowMenuAccelerators". I found the code to remove them is at MainWindow.cpp:177 So, it seems the code removes accelerators correctly, but the problem is that after all menu items got unbound, Alt still is. I don't know what to do with it. I asked on #Qt irc, hopefully someone knows. Good news, I wrote a code, and managed to make it work. Now, where should I send the patch? I found a mailing list, but it has no patches, so probably not there. I also heard, KDE was migrating to gitlab…? Created attachment 121987 [details]
Fix for menu accelerators
Okay, for now I'll attach the patch here.
Okay, I occasionally found¹: I have to move over to phabricator, attach the patch there, and choose the project I'm attaching it for. Done!² 1: https://community.kde.org/Infrastructure/Github_Mirror 2: https://phabricator.kde.org/D22980 Git commit 0107e68e22d3b70bb7bd7002e38d94f6e6e961ce by Kurt Hindenburg, on behalf of Konstantin Kharlamov. Committed on 07/08/2019 at 14:22. Pushed by hindenburg into branch 'master'. Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde When XDG_CURRENT_DESKTOP ≠ kde, perssing and immediately releasing Alt key makes focus get stuck in menu. Fix this by overriding QProxyStyle. This does not influence menu accelerators (e.g. Alt+f to access "File" in menu), which continue working according to user settings. Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru> FIXED-IN: 19.08 Differential Revision: https://phabricator.kde.org/D22980 M +17 -0 src/main.cpp https://invent.kde.org/kde/konsole/commit/0107e68e22d3b70bb7bd7002e38d94f6e6e961ce Git commit 0107e68e22d3b70bb7bd7002e38d94f6e6e961ce by Kurt Hindenburg, on behalf of Konstantin Kharlamov. Committed on 07/08/2019 at 14:22. Pushed by scmsync into branch 'master'. Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde When XDG_CURRENT_DESKTOP ≠ kde, perssing and immediately releasing Alt key makes focus get stuck in menu. Fix this by overriding QProxyStyle. This does not influence menu accelerators (e.g. Alt+f to access "File" in menu), which continue working according to user settings. Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru> FIXED-IN: 19.08 Differential Revision: https://phabricator.kde.org/D22980 M +17 -0 src/main.cpp https://commits.kde.org/konsole/0107e68e22d3b70bb7bd7002e38d94f6e6e961ce Git commit f8f7b43936b7b3718383d3a3ca67a387e28a3089 by Kurt Hindenburg, on behalf of Konstantin Kharlamov. Committed on 07/08/2019 at 14:30. Pushed by hindenburg into branch 'Applications/19.08'. Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde When XDG_CURRENT_DESKTOP ≠ kde, perssing and immediately releasing Alt key makes focus get stuck in menu. Fix this by overriding QProxyStyle. This does not influence menu accelerators (e.g. Alt+f to access "File" in menu), which continue working according to user settings. Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru> FIXED-IN: 19.08 Differential Revision: https://phabricator.kde.org/D22980 (cherry picked from commit 0107e68e22d3b70bb7bd7002e38d94f6e6e961ce) M +17 -0 src/main.cpp https://invent.kde.org/kde/konsole/commit/f8f7b43936b7b3718383d3a3ca67a387e28a3089 Git commit f8f7b43936b7b3718383d3a3ca67a387e28a3089 by Kurt Hindenburg, on behalf of Konstantin Kharlamov. Committed on 07/08/2019 at 14:30. Pushed by scmsync into branch 'Applications/19.08'. Fix focus getting stuck in menu when XDG_CURRENT_DESKTOP ≠ kde When XDG_CURRENT_DESKTOP ≠ kde, perssing and immediately releasing Alt key makes focus get stuck in menu. Fix this by overriding QProxyStyle. This does not influence menu accelerators (e.g. Alt+f to access "File" in menu), which continue working according to user settings. Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru> FIXED-IN: 19.08 Differential Revision: https://phabricator.kde.org/D22980 (cherry picked from commit 0107e68e22d3b70bb7bd7002e38d94f6e6e961ce) M +17 -0 src/main.cpp https://commits.kde.org/konsole/f8f7b43936b7b3718383d3a3ca67a387e28a3089 |