| Summary: | In 'Confirm Close' dialog, pressing 'Close current Tab' causes crash | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Kurt Hindenburg <khindenburg> |
| Component: | general | Assignee: | Konsole Bugs <konsole-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | jimtahu |
| Priority: | NOR | Keywords: | drkonqi |
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/konsole/3c25aafdbaf743665aa2fc0c2c6effc36c35e09c | Version Fixed/Implemented In: | 19.08.1 |
| Sentry Crash Report: | |||
| Attachments: | New crash information added by DrKonqi | ||
|
Description
Kurt Hindenburg
2019-08-05 14:23:11 UTC
Git commit a49332e5537d0da7236ffee7bc8104407e1e8a06 by Kurt Hindenburg. Committed on 07/08/2019 at 00:52. Pushed by hindenburg into branch 'Applications/19.08'. Do not allow 'Close Current Tab" to crash For now just comment out code for 19.08 M +4 -0 src/MainWindow.cpp https://invent.kde.org/kde/konsole/commit/a49332e5537d0da7236ffee7bc8104407e1e8a06 Git commit a49332e5537d0da7236ffee7bc8104407e1e8a06 by Kurt Hindenburg. Committed on 07/08/2019 at 00:52. Pushed by scmsync into branch 'Applications/19.08'. Do not allow 'Close Current Tab" to crash For now just comment out code for 19.08 M +4 -0 src/MainWindow.cpp https://commits.kde.org/konsole/a49332e5537d0da7236ffee7bc8104407e1e8a06 Git commit 62a5f1d7947d4f101d036ba98c9b6cccc3b69a97 by Kurt Hindenburg.
Committed on 18/08/2019 at 20:51.
Pushed by hindenburg into branch 'master'.
Fix crash on "Close Current Tab" handling
Summary:
_pluggedController disconnection happens when session is closed
by closeInNormalWay or closeInForceWay and calling
disconnectController leads to Konsole crash. Also a case when
closeInNormalWay is false was not considered.
FIXED-IN: 19.08.1
Test Plan:
1. Open Konsole
2. Open one more tab
3. Try to close Konsole
4. Pick option "Close Current Tab" (assuming you have not check
'Do not ask again')
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D23246
M +5 -2 src/MainWindow.cpp
https://invent.kde.org/kde/konsole/commit/62a5f1d7947d4f101d036ba98c9b6cccc3b69a97
Git commit 62a5f1d7947d4f101d036ba98c9b6cccc3b69a97 by Kurt Hindenburg.
Committed on 18/08/2019 at 20:51.
Pushed by scmsync into branch 'master'.
Fix crash on "Close Current Tab" handling
Summary:
_pluggedController disconnection happens when session is closed
by closeInNormalWay or closeInForceWay and calling
disconnectController leads to Konsole crash. Also a case when
closeInNormalWay is false was not considered.
FIXED-IN: 19.08.1
Test Plan:
1. Open Konsole
2. Open one more tab
3. Try to close Konsole
4. Pick option "Close Current Tab" (assuming you have not check
'Do not ask again')
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D23246
M +5 -2 src/MainWindow.cpp
https://commits.kde.org/konsole/62a5f1d7947d4f101d036ba98c9b6cccc3b69a97
Git commit 3c25aafdbaf743665aa2fc0c2c6effc36c35e09c by Kurt Hindenburg, on behalf of Andrey Yashkin.
Committed on 18/08/2019 at 21:36.
Pushed by hindenburg into branch 'Applications/19.08'.
Fix crash on "Close Current Tab" handling
Summary:
_pluggedController disconnection happens when session is closed
by closeInNormalWay or closeInForceWay and calling
disconnectController leads to Konsole crash. Also a case when
closeInNormalWay is false was not considered.
FIXED-IN: 19.08.1
Test Plan:
1. Open Konsole
2. Open one more tab
3. Try to close Konsole
4. Pick option "Close Current Tab" (assuming you have not check
'Do not ask again')
M +5 -6 src/MainWindow.cpp
https://invent.kde.org/kde/konsole/commit/3c25aafdbaf743665aa2fc0c2c6effc36c35e09c
Git commit 3c25aafdbaf743665aa2fc0c2c6effc36c35e09c by Kurt Hindenburg, on behalf of Andrey Yashkin.
Committed on 18/08/2019 at 21:36.
Pushed by scmsync into branch 'Applications/19.08'.
Fix crash on "Close Current Tab" handling
Summary:
_pluggedController disconnection happens when session is closed
by closeInNormalWay or closeInForceWay and calling
disconnectController leads to Konsole crash. Also a case when
closeInNormalWay is false was not considered.
FIXED-IN: 19.08.1
Test Plan:
1. Open Konsole
2. Open one more tab
3. Try to close Konsole
4. Pick option "Close Current Tab" (assuming you have not check
'Do not ask again')
M +5 -6 src/MainWindow.cpp
https://commits.kde.org/konsole/3c25aafdbaf743665aa2fc0c2c6effc36c35e09c
Created attachment 163598 [details]
New crash information added by DrKonqi
konsole (23.08.3) using Qt 5.15.11
Launched discord via the comand line in a new konsole tab, it needed and update, but froze when I tried to close, so I closed the tab to force the situation. Hit the confirmation dialog and then had this crash.
It looked like kwin / plasma may have reloaded? This may just have been a trick of the window disapearing.
-- Backtrace (Reduced):
#6 QWeakPointer<QObject>::QWeakPointer (other=..., this=this@entry=0x7ffdfa5f84f0) at /usr/include/qt5/QtCore/qsharedpointer_impl.h:589
#7 QPointer<Konsole::Session>::QPointer (this=this@entry=0x7ffdfa5f84f0) at /usr/include/qt5/QtCore/qpointer.h:53
#8 Konsole::SessionDisplayConnection::session (this=0xa7000000a6) at /var/tmp/portage/kde-apps/konsole-23.08.3/work/konsole-23.08.3/src/session/SessionDisplayConnection.cpp:25
#9 0x00007f815366c91d in Konsole::SessionController::session (this=0x7f813c078650) at /var/tmp/portage/kde-apps/konsole-23.08.3/work/konsole-23.08.3/src/session/SessionController.h:94
#10 Konsole::SessionController::closeSession (this=0x7f813c078650) at /var/tmp/portage/kde-apps/konsole-23.08.3/work/konsole-23.08.3/src/session/SessionController.cpp:1214
|