Summary: | When Text Files preview is enabled, .directory files should still show their icon instead of their text contents (i.e. behave like .desktop files) | ||
---|---|---|---|
Product: | [Frameworks and Libraries] kio-extras | Reporter: | Alexander M. <apmichalopoulos> |
Component: | Thumbnails and previews | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | apmichalopoulos, bugseforuns, elvis.angelaccio, nate |
Priority: | NOR | Keywords: | usability |
Version: | 19.04.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kio-extras/df85d47c7242aeb7b713de48049891628254a67d | Version Fixed In: | 19.08.0 |
Attachments: |
Text Files preview disabled
Text Files preview enabled |
Description
Alexander M.
2019-08-04 08:17:52 UTC
Created attachment 121925 [details]
Text Files preview disabled
Created attachment 121926 [details]
Text Files preview enabled
.flatpakref issue already reported as bug 400201 Submitted a patch: https://phabricator.kde.org/D22936 Git commit df85d47c7242aeb7b713de48049891628254a67d by Nate Graham. Committed on 08/08/2019 at 14:00. Pushed by ngraham into branch 'Applications/19.08'. [Text thumbnailer] Don't show text preview for .directory and .flatpakref files Summary: The text thumbnailer currently excludes .directory files from receiving text file thumbnails, but does not do the same for .directory and .flatpakref files which are the same things (actually text files that don't look, feel, or behave like text files). This patch extends the same logic to those types of files as well, making them not receive text previews and instead show their base mimetype or icon (if defined in the file). Related: bug 400201 FIXED-IN: 19.08.0 Test Plan: {F7161776, size=full} Reviewers: #vdg, #frameworks, broulik Reviewed By: broulik Subscribers: kde-frameworks-devel, kfm-devel Tags: #dolphin, #frameworks Differential Revision: https://phabricator.kde.org/D22936 M +6 -2 thumbnail/textcreator.cpp https://commits.kde.org/kio-extras/df85d47c7242aeb7b713de48049891628254a67d |