Summary: | Show tagged files and folders first/before untagged ones | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | george fb <georgefb899> |
Component: | view-engine: general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | elvis.angelaccio, nate, nazark |
Priority: | NOR | Keywords: | junior-jobs, usability |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
See Also: | https://bugs.kde.org/show_bug.cgi?id=406296 | ||
Latest Commit: | https://commits.kde.org/dolphin/7f6d49377b3b66da9811d94aa0166872e4f44836 | Version Fixed In: | 19.11.80 |
Description
george fb
2019-08-03 13:35:08 UTC
I guess the issue is also with other textual columns, such as Artist, Comment, etc.). For all those textual columns, an empty string could always sort after a non-empty string, even in reverse sorting mode. Compariso code is in https://cgit.kde.org/dolphin.git/tree/src/kitemviews/kfileitemmodel.cpp#n1741 I wrote a patch (probably an awful one, because I'm not a C++ dev) with a fix for that. With this patch tagged folders come before untagged and tagged files come before untagged files, and I think the same applies to "other textual columns, such as Artist, Comment, etc". Should I try to submit it, or should I try to add a setting to make this behavior optional, not default? Git commit 7f6d49377b3b66da9811d94aa0166872e4f44836 by Elvis Angelaccio, on behalf of Nazar Kalinowski. Committed on 01/09/2019 at 15:50. Pushed by elvisangelaccio into branch 'master'. Make non-empty textual columns come first in sorting Summary: Current behavior of dolphin in sorting of files with textual columns (e.g. tags) is to show files without this particular textual column (e.g. without tags) first. This patch changes this behavior so that dolphin shows the files with some value before the files without any value for chosen sorting method. Test Plan: Sorting by name (isn't affected by the patch): https://i.imgur.com/eqbYwyZ.png Sorting by textual column ("tags" in this particular example), old version (non-tagged files and folders come first): https://i.imgur.com/5KLLujU.png patched version (tagged files and folders come first): https://i.imgur.com/oUAeZ2z.png Reviewers: #dolphin, #vdg, ngraham Reviewed By: #dolphin, #vdg, ngraham Subscribers: elvisangelaccio, ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23482 M +9 -2 src/kitemviews/kfileitemmodel.cpp https://commits.kde.org/dolphin/7f6d49377b3b66da9811d94aa0166872e4f44836 |