Bug 410533

Summary:	SHIFT key doesn't change size
Product:	[Applications] krita	Reporter:	Luciano <eulucianosalomoni>
Component:	Brush Engine/Shape	Assignee:	Krita Bugs <krita-bugs-null>
Status:	CONFIRMED ---
Severity:	wishlist	CC:	hrittik.lone.wolf, rebuilderster, scottpetrovic, tamtamy.tymona
Priority:	NOR
Version First Reported In:	4.2.5
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Luciano 2019-08-03 08:57:21 UTC

SUMMARY
When in brush tool SHIFT + CLICK + DRAG changes brush size.

But, when in any shape tool - rectangle, elipse, polyline - SHIFT + CLICK + DRAG does nothing. It is supoused to change the brush size too - once these shape tools are draw tools. 

*When you CLICK + SHIFT + DRAG it makes a perfect shape (circle, square) as desired. The issue is when SHIFT comes first.

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Scott Petrovic 2019-08-05 15:25:34 UTC

I this would need some discussion to figure out what we would want to do with it. Holding down shift does different things with different tools, so making all tools do brush resize would collide with other shortcuts.

For example, holding down SHIFT after clicking make the rectangle tool constrain to a perfect square. Holding Shift after clicking the polygon tool closes the shape after another tool.

I see where you are coming from with making the shortcut consistent across tools, but we would need to figure out how to remap or change the existing shortcuts that already use shift.

Comment 2 Luciano 2019-08-05 20:38:58 UTC

Hi Scott. Thanks for your time.

I think I couldn't explain my idea or I didn't understand what you explained (I'm not a English speaker).

You are right about the consist proportion function. But notice that it works when you hold [SHIFT] AFTER the click. CLICK>SHIFT>DRAG

My point is to resize the brush - by holding [SHIFT] - BEFORE the click. SHIFT>CLICK>DRAG
Now, holding [SHIFT] before click in shape tools does nothing. So I think filling this "nothing" with the resize function could be a nice idea.

Hope my words made sense now.

Comment 3 Hrittik Das 2019-12-17 08:07:29 UTC

Is anyone working on it?

I was talking to some developers in the IRC and got to know that the brush size feature is implemented in kis_change_primary_setting_action.cpp file. Should I make changes in the file?

Comment 4 Tiar 2021-03-28 01:59:00 UTC

Setting to wish, since it's about a new behaviour (since it will be a new behaviour for those tools).

@Hrittik Das no, no one is working on it at the moment. Are you still interested?

Comment 5 Tiar 2024-01-22 08:03:11 UTC

*** Bug 477351 has been marked as a duplicate of this bug. ***