Summary: | File won't open in new version of Krita due triple period unicode character. | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | dinarnorlund |
Component: | File formats | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | griffinvalley, halla, moje.mody |
Priority: | NOR | ||
Version: | 4.2.3 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Other | ||
Latest Commit: | https://invent.kde.org/kde/krita/commit/93e737e74eb930e6384999e2c350d7803d844567 | Version Fixed In: | |
Attachments: |
Comic page that causes Krita to crash, link to drive download
the SVG of the shapelayer that refuses to open. |
Description
dinarnorlund
2019-07-30 14:02:17 UTC
Created attachment 121839 [details]
Comic page that causes Krita to crash, link to drive download
File too big to attach, see link to drive download
Created attachment 121840 [details]
the SVG of the shapelayer that refuses to open.
So, after looking into the file, there was only one layer which was different from the rest: the text vector layer. Removing this layer from maindoc.xml and repacking led to the kra file being possible to be opened. Trying to open the text svg seperately leads to Krita freezing up again.
So, we need to figure out what it is about this svg that makes Krita 4.2 unhappy, but Krita 4.1.7 is fine with.
I've found the culprit, it's '…', or a triple period unicode character. Git commit fa5d8d30db3421bf022f94f53b96b34b868f8492 by Boudewijn Rempt. Committed on 02/09/2019 at 08:09. Pushed by rempt into branch 'rempt/bug-410402'. Do not hang on loading text containing triple-dot Break the loop: if adding an offset to the number of columns doesn't increase the line length, we break out of the loop to avoid an infinite loop on loading some files. M +4 -0 libs/flake/text/KoSvgTextShape.cpp https://invent.kde.org/kde/krita/commit/fa5d8d30db3421bf022f94f53b96b34b868f8492 *** This bug has been marked as a duplicate of bug 409617 *** Git commit cd3313794491fc6409e0a9db31d2813920c7192b by Ivan Yossi. Committed on 04/09/2019 at 23:36. Pushed by ivany into branch 'rempt/bug-410402'. Fix hang when utf line break is used Shift + Enter creates an utf break character which breaks the lenght calculation. Also added a reptition flag to avoid any other hang if there is a strange symbol. M +1 -1 libs/flake/text/KoSvgTextChunkShape.cpp M +9 -2 libs/flake/text/KoSvgTextShape.cpp https://invent.kde.org/kde/krita/commit/cd3313794491fc6409e0a9db31d2813920c7192b Git commit 535ca1fc6fde92003258c2dd861e05cce3bf8004 by Ivan Yossi. Committed on 11/09/2019 at 23:27. Pushed by ivany into branch 'master'. Fix hang when utf line break is used Break the loop: if adding an offset to the number of columns doesn't increase the line length, we break out of the loop to avoid an infinite loop on loading some files. Shift + Enter creates an utf break character which breaks the lenght calculation. Also added a reptition flag to avoid any other hang if there is a strange symbol. ref:https://invent.kde.org/kde/krita/merge_requests/128 M +1 -1 libs/flake/text/KoSvgTextChunkShape.cpp M +11 -0 libs/flake/text/KoSvgTextShape.cpp https://invent.kde.org/kde/krita/commit/535ca1fc6fde92003258c2dd861e05cce3bf8004 *** Bug 411829 has been marked as a duplicate of this bug. *** Git commit 93e737e74eb930e6384999e2c350d7803d844567 by Ivan Yossi. Committed on 12/09/2019 at 04:59. Pushed by ivany into branch 'krita/4.2'. Fix hang when utf line break is used Break the loop: if adding an offset to the number of columns doesn't increase the line length, we break out of the loop to avoid an infinite loop on loading some files. Shift + Enter creates an utf break character which breaks the lenght calculation. Also added a reptition flag to avoid any other hang if there is a strange symbol. ref:https://invent.kde.org/kde/krita/merge_requests/128 (cherry picked from commit 535ca1fc6fde92003258c2dd861e05cce3bf8004) M +1 -1 libs/flake/text/KoSvgTextChunkShape.cpp M +11 -0 libs/flake/text/KoSvgTextShape.cpp https://invent.kde.org/kde/krita/commit/93e737e74eb930e6384999e2c350d7803d844567 |