Bug 410374

Summary: ‘Create Filter Mask’ button is inconsistently disabled/enabled
Product: [Applications] krita Reporter: Karl Ove Hufthammer <karl>
Component: Filter LayersAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: halla
Priority: NOR    
Version: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/kde/krita/commit/4ae537e2f74566fff9fdd5abece292fc03cad794 Version Fixed In:

Description Karl Ove Hufthammer 2019-07-29 21:34:56 UTC 
SUMMARY
The ‘Create Filter Mask’ button is inconsistently disabled/enabled. I think the idea is that it should be disabled for filters that can’t be used as filter layers (though I’m not sure which filters have this property). But currently, whether it’s disabled (greyed out) or enabled depends on the filter used to *open* the filter dialogue, not on the currently selected filter.

STEPS TO REPRODUCE
1. Create/open an image.
2. Select ‘Filter → Other → Random Pick’.
3. Select ‘Wave’ in filter sidebar.
4. Select ‘Filter → Other → Wave’.
5. Select ‘Random Pick’ in filter sidebar.

OBSERVED RESULT
In steps 3 and 4, the ‘Create Filter Mask’ button is enabled.
In steps 4 and 5, the ‘Create Filter Mask’ button is disabled.


EXPECTED RESULT
Whether the ‘Create Filter Mask’ button is enabled or disabled should depend on the *currently selected* filter, not on the filter used to open the filter dialogue.


SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20190726
KDE Plasma Version: 5.16.3
KDE Frameworks Version: 5.60.0
Qt Version: 5.13.0
Kernel Version: 5.2.2-1-default
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-2500 CPU @ 3.30GHz
Memory: 15,6 GiB
Comment 1 Halla Rempt 2019-07-30 08:19:19 UTC 
Yes, you're right.
Comment 2 wolthera 2019-08-02 11:18:51 UTC 
Git commit 3af6ef5c71a3f4f326c4f84c59f8c6eec2ae0b92 by Wolthera van Hövell tot Westerflier.
Committed on 02/08/2019 at 11:18.
Pushed by woltherav into branch 'master'.

This one is in the category: how did this not break sooner, but alas.

M  +1    -0    libs/ui/dialogs/kis_dlg_filter.cpp

https://invent.kde.org/kde/krita/commit/3af6ef5c71a3f4f326c4f84c59f8c6eec2ae0b92
Comment 3 Halla Rempt 2019-08-02 12:13:11 UTC 
Git commit 4ae537e2f74566fff9fdd5abece292fc03cad794 by Boudewijn Rempt, on behalf of Wolthera van Hövell tot Westerflier.
Committed on 02/08/2019 at 12:13.
Pushed by rempt into branch 'krita/4.2'.

This one is in the category: how did this not break sooner, but alas.

M  +1    -0    libs/ui/dialogs/kis_dlg_filter.cpp

https://invent.kde.org/kde/krita/commit/4ae537e2f74566fff9fdd5abece292fc03cad794