| Summary: | Inconsistent navigation of blending modes with keyboard | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Karl Ove Hufthammer <karl> |
| Component: | Layer Stack | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73, ghevan, halla |
| Priority: | NOR | ||
| Version: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/b053074393d9080dbb269d83c8df6dcb18e54a67 | Version Fixed In: | |
| Attachments: | Video showing the bug in action | ||
|
Description
Karl Ove Hufthammer
2019-07-28 14:07:56 UTC
Hi! I tried reproducing following the instructions you posted but I could not, up and down scrolled trough content in order, however it was not limited to visible blending modes. could you post a video to understan what is happening? Created attachment 121800 [details]
Video showing the bug in action
Here’s a video showing how blending mode selection works when I press the down arrow key. Looking at the video, I noticed that right before cycling back to the ‘Normal’ mode, a different mode is selected, but just for a fraction of a second. Perhaps that’s a clue to what’s causing the bug?
(Removed NEEDSINFO status.) Im not sure we can do much here, the behaviour seems to have changed in our framework of choice. Now when the cursor gets to a "category title" entry it resets to "Normal" This is not reproductible in macos as the blending combobox never keeps focus. I've seen this happen on Linux as well, it might be a regression in Qt's handling of itemviews, or it might be something we can work around. I can reproduce the issue on Windows Git commit 66068abb8878a21fa2a3f0db3ec105e4105c7123 by Dmitry Kazakov. Committed on 18/08/2020 at 21:14. Pushed by dkazakov into branch 'krita/4.3'. Fix jumps in composite op combobox when using mouse wheel or keyboard 1) In KisCompositeOpComboBox::selectCompositeOp() we shouldn't reselect the same composite op all the time. Composite ops are not unique in the list (they are duplicated in favourite category), therefore such reselection may break the order. 2) keyPressEvent() and wheelEvent() should skip category items. Otherwise it would fallback to "Normal" blending mode. 3) KisSortedCategorizedListModel::indexOf() should search for the element in the order of the sorted model, not the original one. Obviously, we should first select from "Favourite" category. M +17 -2 libs/ui/kis_categorized_list_model.h M +152 -0 libs/ui/widgets/kis_cmb_composite.cc M +3 -0 libs/ui/widgets/kis_cmb_composite.h https://invent.kde.org/graphics/krita/commit/66068abb8878a21fa2a3f0db3ec105e4105c7123 Git commit b053074393d9080dbb269d83c8df6dcb18e54a67 by Dmitry Kazakov. Committed on 18/08/2020 at 21:14. Pushed by dkazakov into branch 'master'. Fix jumps in composite op combobox when using mouse wheel or keyboard 1) In KisCompositeOpComboBox::selectCompositeOp() we shouldn't reselect the same composite op all the time. Composite ops are not unique in the list (they are duplicated in favourite category), therefore such reselection may break the order. 2) keyPressEvent() and wheelEvent() should skip category items. Otherwise it would fallback to "Normal" blending mode. 3) KisSortedCategorizedListModel::indexOf() should search for the element in the order of the sorted model, not the original one. Obviously, we should first select from "Favourite" category. M +17 -2 libs/ui/kis_categorized_list_model.h M +152 -0 libs/ui/widgets/kis_cmb_composite.cc M +3 -0 libs/ui/widgets/kis_cmb_composite.h https://invent.kde.org/graphics/krita/commit/b053074393d9080dbb269d83c8df6dcb18e54a67 |