Bug 410125

Summary:	"Preserve aspect ratio" when cropping should be off by default
Product:	[Applications] gwenview	Reporter:	priomsrb
Component:	general	Assignee:	Gwenview Bugs <gwenview-bugs-null>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	nate, priomsrb
Priority:	NOR
Version First Reported In:	19.04.2
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description priomsrb 2019-07-23 00:44:29 UTC

"Preserve aspect ratio" when cropping should be off by default  


STEPS TO REPRODUCE
1. I tried to use the crop tool in gwenview for the first time. I was surprised that it wouldn't let me crop in the exact size I wanted. It would try to keep the crop in the image aspect ratio. I thought this was a bug and began googling online if there is an existing bug.

After 10 minutes of not finding an existing bug report, I realized that there was "Preserve aspect ratio" option checked at the bottom of the window. This option is easy to miss. I worry that some less experienced users may miss this as well. 

OBSERVED RESULT
"Preserve aspect ratio" is on by default.


EXPECTED RESULT
"Preserve aspect ratio" should be off by default. In other cropping tools, you're able to crop in arbitrary ratios by default. And if I want to maintain the aspect ratio, I can just hold down the shift key.


SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.15.5
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.3
Kernel Version: 4.19.49-1-MANJARO
OS Type: 64-bit


ADDITIONAL INFORMATION

Comment 1 Nate Graham 2019-07-23 16:54:43 UTC

Yes, I agree. This has been irritating me as well.

Comment 2 Nate Graham 2019-07-23 17:38:10 UTC

While digging through the code to produce a patch for this, I found that it actually is off by default! I verified this by logging into a new user account and launching Gwenview. Sure enough, the preserve aspect ratio checkbox isn't checked.

This was all done on Manjaro - the same distro that you're using. So now I can't even blame the distro overriding the default settings. :) I suspect that maybe you or someone else accidentally checked the checkbox and forgot about it.

Comment 3 priomsrb 2019-07-24 06:18:18 UTC

That is odd. I'm not sure how it was enabled for me. It could've been accidentally toggled by me. Though it took me 10 mins to spot the setting in the first place haha.

One possibility is that when I updated my gwenview from 18.12.3-1 to 19.04.2-1, it somehow messed with the configuration. I'll see if I can reproduce that.

Comment 4 priomsrb 2019-07-24 07:21:07 UTC

I just tried running a virtual box with an old version of gwenview, copying that config, and trying it on my current version of gwenview. I wasn't able to reproduce the checkbox being checked by default. So maybe I DID somehow trigger the checkbox accidentally.