Bug 410055

Summary:	filter layer and filter mask pop ups are locked to the center of the screen with dark opaque screen overlay
Product:	[Applications] krita	Reporter:	Toby <tobywillsmer>
Component:	Filter Layers	Assignee:	vanyossi <ghevan>
Status:	RESOLVED NOT A BUG
Severity:	major	CC:	ghevan, halla
Priority:	NOR
Version First Reported In:	4.2.3
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Toby 2019-07-21 00:07:14 UTC

SUMMARY
The filter layer and filter mask layers pop ups are locked centrally to the screen and have a dark opaque screen overlay that hinders any accurate colour adjustments being made due to the dark overlay.

Versions:
It's worth noting that v4.2.1 works as I expect with no overlay and the pop ups being moveable with click and drag.
All versions after v4.2.1 have the locked position and screen overlay problem

The overlay problem is similar to Bug 384870 but it's not environmental as the v4.2.1 version works fine along side the newer versions (v4.2.2 & v4.2.3) that do not


STEPS TO REPRODUCE
1. open or create a file with a normal drawing layer
2. use the small '+' icon in the layer docker to create either a filter layer or a filter mask on the drawing layer
3. the popup and overlay appear

OBSERVED RESULT

The popup appears and is not moveable from the center position with click and drag.
When trying to move it by click and drag the whole app shrinks and moves on drag

When the pop up is visible the whole screen has the dark opaque overlay, this makes any colour changes (i.e saturation) from within the filter layer pop ups hard as you cannot accurately see what the changing colours are due to the dark overlay.

This is also happening when you go to edit either an existing filter layer or mask layer but this happens in all the mentioned versions here


EXPECTED RESULT
the popup windows should to be moveable around the screen on click and drag with no dark screen overlay.


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Ubunutu 18.04.2 LTS
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 vanyossi 2019-07-22 02:47:01 UTC

Hi!

Im sorry but this is not a bug in krita but a behaviour on your window manager. Try to see if you can disable dark overlay for popup windows system wise.

Im using xfce and macOs and none of them have that problem, o Kde by default the parent modal dialogs darken the background. To disable:

- KDE Settings > Desktop Effects > Dialog Parent: disable
- Apply

On KDE by default it is possible to move the window, so to move a modal window you will need to move something else in your system preferences. What desktop environment are you using?

Disabling this might be a little different on other desktop environments.

Comment 2 Toby 2019-07-22 03:32:46 UTC

(In reply to vanyossi from comment #1)
> Hi!
> 
> Im sorry but this is not a bug in krita but a behaviour on your window
> manager. Try to see if you can disable dark overlay for popup windows system
> wise.
> 
> Im using xfce and macOs and none of them have that problem, o Kde by default
> the parent modal dialogs darken the background. To disable:
> 
> - KDE Settings > Desktop Effects > Dialog Parent: disable
> - Apply
> 
> On KDE by default it is possible to move the window, so to move a modal
> window you will need to move something else in your system preferences. What
> desktop environment are you using?
> 
> Disabling this might be a little different on other desktop environments.

Not sure this is the case for Linux users as this issue is only for these two specific layer types. 
I'm running Ubuntu 18.0.4 and I can run the v4.2.1 app image and everything works as normal. It's any app image version after that the issue has become a problem. For pretty much all the other pop up windows in Krita they are fine, it's these two layer types that have changed since v4.2.1.

Comment 3 Bug Janitor Service 2019-07-22 04:33:11 UTC

Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

Comment 4 vanyossi 2019-07-22 04:55:05 UTC

When we fixed bug 408867 we created this behaviour.


What Desktop Environment are you using in your Ubuntu? (as said before on KDE this is an easy fix). I need to know to try and reproduce what you are getting and try to fix it without breaking the previous fix.

Comment 5 Toby 2019-07-22 06:14:17 UTC

it's the default GNOME 3 for 18.0.4 desktop

Comment 6 Bug Janitor Service 2019-07-23 04:33:09 UTC

Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

Comment 7 Halla Rempt 2019-07-23 12:34:23 UTC

The difference is that since this release, those dialogs now have the main window as parent. That makes your window manager treat them this way; having the parent set is the proper thing, and your window manager should have an option to disable this behaviour.