Summary: | Quietly "saves" invalid event (incidence) start or end times as midnight (particularly affects fr_CA sub-locale) | ||
---|---|---|---|
Product: | [Applications] korganizer | Reporter: | Philippe Cloutier <chealer> |
Component: | incidence editors | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | gjditchfield |
Priority: | NOR | ||
Version: | 5.10.3 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
See Also: | https://bugs.kde.org/show_bug.cgi?id=409867 | ||
Latest Commit: | Version Fixed In: | 5.16.0 | |
Sentry Crash Report: |
Description
Philippe Cloutier
2019-07-17 19:15:58 UTC
It seems this has also multiplied the impact of another issue, reported in issue report #361764. However, that mentions the impact could be either a quiet data loss, *or an inability to save events*, depending on the calendar time. Perhaps incidenceeditor has changed since then. Git commit 701db76dc643d04fff14f9ee3875cd6654efdd34 by Glen Ditchfield. Committed on 01/11/2020 at 02:01. Pushed by gditchfield into branch 'master'. Detect invalid start and end times If the user enters an invalid string such as "25:00" into the start time field or the end/due time field, IncidenceDateTime does not detect it, because the QDateTime constructor used by currentStartDateTime() and currentEndDateTime() treats it as "00:00". This patch * detects and reports the error, * uses more specific error messages, * focuses on the erroneous field, and * logs at "debug" level, because the problem isn't very big. M +14 -0 autotests/CMakeLists.txt A +90 -0 autotests/incidencedatetimetest.cpp [License: LGPL(v2.0+)] M +55 -10 src/incidencedatetime.cpp M +2 -0 src/incidencedatetime.h https://invent.kde.org/pim/incidenceeditor/commit/701db76dc643d04fff14f9ee3875cd6654efdd34 |