| Summary: | Crash on shortcut conflict when Escape key is bound to Quit | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | Michal Mutl <michal.mutl> |
| Component: | application | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | christoph, nate |
| Priority: | NOR | ||
| Version First Reported In: | 19.04.2 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://commits.kde.org/kate/8a429fef3fcc412ee607b3834744a3e5248eb272 | Version Fixed/Implemented In: | 19.12.0 |
| Sentry Crash Report: | |||
|
Description
Michal Mutl
2019-07-16 10:20:08 UTC
Could you try the nightly installer? https://binary-factory.kde.org/view/Windows%2064-bit/job/Kate_Nightly_win64/ I thought I have fixed such a crash (that happened on Linux, too) in the last weeks. (In reply to Christoph Cullmann from comment #1) > Could you try the nightly installer? > > https://binary-factory.kde.org/view/Windows%2064-bit/job/Kate_Nightly_win64/ > > I thought I have fixed such a crash (that happened on Linux, too) in the > last weeks. Yes, this build is ok regarding to crash. But behaviour is wrong. Esc key should leave Quick Open but instead quits Kate. Yes Esc is assigned as Quit shortcut, but in this case Esc should really leave Quick Open. The same when user press Esc to leave e.g. configuration dialog. It also does not quit Kate but only leaves dialog. In the configuration dialog you have a separate event loop, that's why ESC will likely just close the dialog. However, the quick open does not have its own dialog and is embedded in the main window. ESC simply triggers the application action for you, so this is expected behavior. I think we should check once how ESC is caught in quick open, so we may be able to fix it. But it's really a corner case and not really a bug, imho. Yes, I know why it works in dialogs, I just say that it's illogical in Quick Open case. Would it be problem to check whether Quick Open is opened and focused when Esc is pressed and if so only close it and do not quit Kate? Git commit 8a429fef3fcc412ee607b3834744a3e5248eb272 by Christoph Cullmann. Committed on 24/08/2019 at 20:39. Pushed by cullmann into branch 'master'. allow ESC to be used as global application shortcut and still exit the quick open same approach as in KTextEditor e.g. search widget M +3 -1 kate/katequickopen.cpp https://invent.kde.org/kde/kate/commit/8a429fef3fcc412ee607b3834744a3e5248eb272 Git commit 8a429fef3fcc412ee607b3834744a3e5248eb272 by Christoph Cullmann. Committed on 24/08/2019 at 20:39. Pushed by scmsync into branch 'master'. allow ESC to be used as global application shortcut and still exit the quick open same approach as in KTextEditor e.g. search widget M +3 -1 kate/katequickopen.cpp https://commits.kde.org/kate/8a429fef3fcc412ee607b3834744a3e5248eb272 |