Bug 409807

Summary: Some checkboxes and their labels are misaligned
Product: [Applications] drkonqi Reporter: Patrick Silva <bugseforuns>
Component: generalAssignee: Unassigned bugs mailing-list <unassigned-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: nate, sitter
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: screenshot

Description Patrick Silva 2019-07-15 00:46:35 UTC
Created attachment 121515 [details]
screenshot

SUMMARY
As we can see in the attached screenshot, some checkboxes and their labels are misaligned in the crash reporter. Not always this bug occurs, apparently it is a random bug.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.16.80
KDE Frameworks Version: 5.61.0
Qt Version: 5.12.3
Comment 1 Harald Sitter 2019-07-15 16:39:13 UTC
always reproducible with systemsettings5. I suspect this is a regression caused by the new example label
Comment 2 Harald Sitter 2019-07-20 22:34:54 UTC
Git commit 5a59721d7efe89adbfad2dec39878d65c2655228 by Harald Sitter.
Committed on 20/07/2019 at 22:32.
Pushed by sitter into branch 'master'.

wrap the details example label+spacer in a container widget

Summary:
this way we can control both their visibility in a single call. with the
previous code we'd only set the label as hidden and leave a dangling
spacer to mess with the layout.

Test Plan:
- segv dolphin -> report -> layout shows example
- segv systemsettings5 -> report -> layout shows no example but is correctly spaced

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22485

M  +2    -1    src/bugzillaintegration/reportassistantpages_base.cpp
M  +39   -37   src/bugzillaintegration/ui/assistantpage_bugawareness.ui

https://commits.kde.org/drkonqi/5a59721d7efe89adbfad2dec39878d65c2655228