Summary: | KIO-FTP can't connect to some FTP servers with Turkish locale | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | NXiss7 <nxiss7> |
Component: | FTP | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kdelibs-bugs |
Priority: | NOR | ||
Version: | 5.59.0 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kio/94723d1aa7cac4644c26f8b6c433ec1b8ddd86b7 | Version Fixed In: |
Description
NXiss7
2019-07-12 10:04:33 UTC
It turns out that the application ignores the case (using toUpperCase() function of java.lang.String) . But on Turkish locale, lower-case 'i' converted to upper-case 'İ' instead of 'I' thus client receives "Command not implemented" result. I assume this bug would cause problems on other servers that run with Turkish locale. Git commit 94723d1aa7cac4644c26f8b6c433ec1b8ddd86b7 by Albert Astals Cid, on behalf of Enes Selim. Committed on 21/07/2019 at 08:36. Pushed by aacid into branch 'master'. Fix can't enter directory error on some FTP servers with Turkish locale Summary: Some Android FTP server applications don't implement lower-case "list" command thus KIO can't connect to server and fail with error "Can't enter directory." Sending upper-case "LIST" command works. Edit: It turns out that the application ignores the case (using toUpperCase() function of java.lang.String) . But on Turkish locale, lower-case 'i' converted to upper-case 'İ' instead of 'I' thus client receives "Command not implemented" result. I assume this bug would cause problems on other servers that run with Turkish locale. Test Plan: 1 - Change Android system language to Turkish. 2 - Start FTP server using ES File Manager 3.2.5. 3 - Connect to server using Dolphin. 4 - It should work without errors. Reviewers: #frameworks, dfaure Reviewed By: dfaure Subscribers: dfaure, aacid, svuorela, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D22419 M +7 -3 src/ioslaves/ftp/ftp.cpp https://commits.kde.org/kio/94723d1aa7cac4644c26f8b6c433ec1b8ddd86b7 |