Summary: | Showfoto export WebP images without colour space | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Lapineige <lp.kde> |
Component: | Plugin-DImg-Magick | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caulier.gilles, lp.kde, metzpinguin |
Priority: | NOR | ||
Version: | 5.9.0 | ||
Target Milestone: | --- | ||
Platform: | Kubuntu | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/kde/digikam/commit/f74751a58427223f2568ac3d884be7d875c0e9c6 | Version Fixed In: | 6.2.0 |
Attachments: | iccProfile.patch |
Description
Lapineige
2019-07-11 15:09:31 UTC
Created attachment 121477 [details]
iccProfile.patch
In digiKam-6.2.0, the ImageMagick loader takes care of loading and saving WebP images. This is a first patch to save and load ICC profiles. ImageMagick has a problem if there are XMP metadata in the image when loading, then we fall back to the QImage loader, which can not load ICC profiles. For this we have to find a solution. Also WebP images of Gimp with XMP are rejected by the ImageMagick loader, it is not an Exiv2 problem.
Maik
So I need to report this issue (bug ?) to ImageMagick ? No, I'll take a closer look this evening. ImageMagick's CLI tool issues the same warning but does not stop. We treat the warning as an exception. Maik Ok, the new ImageMagick loader in digiKam-6.2.0 works now fine if a warning occurs. We need to catch warnings of the Magick::Image::read() function. I'm applying the patch tonight. Maik Oh, that's great ! Thanks :) I guess this will also solve the issue with Gwenview ? (same problem) Git commit f74751a58427223f2568ac3d884be7d875c0e9c6 by Maik Qualmann. Committed on 12/07/2019 at 10:33. Pushed by mqualmann into branch 'master'. add read/write ICC Profile to the ImageMagick loader and catch warnings from the Image::read() function FIXED-IN: 6.2.0 M +2 -1 NEWS M +38 -6 core/libs/dimg/loaders/magickloader.cpp https://invent.kde.org/kde/digikam/commit/f74751a58427223f2568ac3d884be7d875c0e9c6 Gwenview is another project. This fix is only for Showfoto and digiKam. I suspect that Gwenview for WebP uses the QImage loader. Qt has no support for color profiles so far. Maik Ok, I was thinking that perhaps they were using the same library. I'll report it to them too. Thanks a lot :) |