Summary: | Plasma 5.16.2 Blur Noise Level Issue | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | duncanyoyo1 |
Component: | compositing | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 5.16.2 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
Plasma 5.16.2 Blur Noise Levels Comparison
Konsole on Pure Black Background Level 6/15 Konsole Blur Level 15 |
Description
duncanyoyo1
2019-07-08 14:48:19 UTC
Created attachment 121386 [details]
Konsole on Pure Black Background Level 6/15
(In reply to duncanyoyo1 from comment #0) > It seems like after this commit > (https://phabricator.kde.org/R108:168109f3bb36882cdd1f18ebe3ce052e4cd608a0) > it has been like this, but I am not sure if it is related. As an author of that commit I assure that it has nothing to do with this bug. If you look closely, that commit was part of KWin since 5.14. This "bug" is most likely caused by the sRGB patch (the one that made the blur effect more "natural"). s/assure/assure you/ Vlad, thank you for the quick reply. I think something needs to be changed, because over a dark background the noise stands out too much now. It looks fine with a light background. Before it looked great with light or dark behind the window. The noise looks quite a bit different from when the noise was implemented. Look at level 15/15 from when the noise was added. And now look at level 15. Maybe a small change to how the values are calculated when the background is dark to make the noise slightly darker? Seems like it is being lightened too much currently. I think since the sRGB change the noise levels need an adjustment. I really like the noise itself, I think it makes a big difference in the look and feel of Plasma. Created attachment 121402 [details]
Konsole Blur Level 15
As of 5.16.3 this seems to be fixed. Thanks everyone! Git commit c193efc96239f1a0611206708b84dba2d7befdaa by David Edmundson, on behalf of Tatsuyuki Ishi. Committed on 01/09/2021 at 21:42. Pushed by davidedmundson into branch 'master'. blur: add noise in perceptual space The previous implementation added noise in linear space, which resulted in the effect becoming more pronounced on black backgrounds. This patch changes the process to be applied in perceptual space, by making the noise addition pass a separate draw call and disabling GL_FRAMEBUFFER_SRGB during that. After this change, noise will look much more suppressed and almost never grainy. This change also changes the range of the noise from [-strength..strength) to [0..strength), as blending can only be either additive or subtractive. As a result, users might need to ramp up their noise parameter after this change. v2: Add more explanation around the draw call. v3: Fix noise not fading out with the fade out effect. v4: Restore an accidentally removed comment. v5: Add CCBUG. v6: Rebase. v7: Fix a formatting issue. M +39 -15 src/effects/blur/blur.cpp M +1 -0 src/effects/blur/blur.h M +5 -20 src/effects/blur/blurshader.cpp https://invent.kde.org/plasma/kwin/commit/c193efc96239f1a0611206708b84dba2d7befdaa |