Bug 409447

Summary: Krusader crashes while starting
Product: [Applications] krusader Reporter: Benjamin Buch <benni.buch>
Component: generalAssignee: Krusader Bugs Distribution List <krusader-bugs-null>
Status: RESOLVED FIXED    
Severity: crash CC: alex.bikadorov, garybuttrum1, krusader-bugs-null, nikita+kde
Priority: NOR Keywords: drkonqi
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Benjamin Buch 2019-07-03 08:08:07 UTC
Application: krusader (2.7.2-dev "Peace of Mind")

Qt Version: 5.12.3
Frameworks Version: 5.60.0
Operating System: Linux 4.15.0-54-generic x86_64
Distribution: KDE neon Testing Edition

-- Information about the crash:
- What I was doing when the application crashed:

I started Krusader. Command line output before crash is:

$ krusader 
10:06:31.480-debug default unknown@0 # System icon theme: "oxygen"
10:06:31.565-warning default unknown@0 # QWidget::insertAction: Attempt to insert null action
10:06:31.566-warning default unknown@0 # QWidget::insertAction: Attempt to insert null action
10:06:31.574-warning default unknown@0 # Trying to convert empty KLocalizedString to QString.
KCrash: crashing... crashRecursionCounter = 2
KCrash: Application Name = krusader path = /usr/bin pid = 6259
KCrash: Arguments: /usr/bin/krusader 
KCrash: Attempting to start /usr/lib/x86_64-linux-gnu/libexec/drkonqi from kdeinit
sock_file=/run/user/1000/kdeinit5__0

[1]+  Angehalten              krusader

The crash can be reproduced every time.

-- Backtrace:
Application: Krusader (krusader), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f648a2c9800 (LWP 5767))]

Thread 3 (Thread 0x7f646cbfb700 (LWP 5769)):
#0  0x00007f647e5ce394 in g_mutex_unlock () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x00007f647e5883ee in ?? () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007f647e5885dc in g_main_context_iteration () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x00007f6484696dcb in QEventDispatcherGlib::processEvents (this=0x7f6468000b20, flags=...) at kernel/qeventdispatcher_glib.cpp:424
#4  0x00007f648463803a in QEventLoop::exec (this=this@entry=0x7f646cbfad70, flags=..., flags@entry=...) at kernel/qeventloop.cpp:225
#5  0x00007f648445f4ca in QThread::exec (this=<optimized out>) at thread/qthread.cpp:531
#6  0x00007f64860b5015 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5
#7  0x00007f6484460c72 in QThreadPrivate::start (arg=0x7f648632cd80) at thread/qthread_unix.cpp:361
#8  0x00007f64823a86db in start_thread (arg=0x7f646cbfb700) at pthread_create.c:463
#9  0x00007f64839c288f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 2 (Thread 0x7f6476ad8700 (LWP 5768)):
#0  0x00007f64839b5bf9 in __GI___poll (fds=0x7f6476ad7ca8, nfds=1, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
#1  0x00007f64817f1747 in ?? () from /usr/lib/x86_64-linux-gnu/libxcb.so.1
#2  0x00007f64817f336a in xcb_wait_for_event () from /usr/lib/x86_64-linux-gnu/libxcb.so.1
#3  0x00007f64798bf578 in QXcbEventQueue::run (this=0x55ad8912dec0) at qxcbeventqueue.cpp:228
#4  0x00007f6484460c72 in QThreadPrivate::start (arg=0x55ad8912dec0) at thread/qthread_unix.cpp:361
#5  0x00007f64823a86db in start_thread (arg=0x7f6476ad8700) at pthread_create.c:463
#6  0x00007f64839c288f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 1 (Thread 0x7f648a2c9800 (LWP 5767)):
[KCrash Handler]
#6  QScopedPointer<QObjectData, QScopedPointerDeleter<QObjectData> >::operator-> (this=0x100000010) at ../../include/QtCore/../../src/corelib/tools/qscopedpointer.h:118
#7  qGetPtrHelper<QScopedPointer<QObjectData, QScopedPointerDeleter<QObjectData> > > (ptr=...) at ../../include/QtCore/../../src/corelib/global/qglobal.h:1038
#8  QAction::d_func (this=0x100000008, this@entry=0x7fffad0b1708) at kernel/qaction.h:63
#9  QAction::setToolTip (this=this@entry=0x100000008, tooltip=...) at kernel/qaction.cpp:793
#10 0x000055ad874b6a13 in ListPanelActions::ListPanelActions (this=0x55ad89858090, parent=<optimized out>, mainWindow=<optimized out>) at ./krusader/Panel/listpanelactions.cpp:142
#11 0x000055ad8748f832 in Krusader::setupActions (this=this@entry=0x55ad8964f320) at ./krusader/krusader.cpp:364
#12 0x000055ad87491ceb in Krusader::Krusader (this=0x55ad8964f320, parser=..., __in_chrg=<optimized out>, __vtt_parm=<optimized out>) at ./krusader/krusader.cpp:155
#13 0x000055ad874736b1 in main (argc=<optimized out>, argv=<optimized out>) at ./krusader/main.cpp:284

Reported using DrKonqi
Comment 1 Alex Bikadorov 2019-07-06 15:11:49 UTC
In the commit 262a96c7 a line got accidentally deleted when picking commits from master.
I recreated the line in stable.

@Benjamin
Thanks for testing the stable branch and reporting!

@Nikita
Please try to cherry-pick the commits from master into stable separately and without changing the author information. Otherwise it gets confusing for me. Thanks.
Comment 2 Nikita Melnichenko 2019-07-07 07:03:57 UTC
Alex, my apologies for introducing the bug. There were a lot of conflicts and I tried to be attentive and careful but still missed that line. I remember running the build, still a puzzle how it happened. I'll try not to merge commits in the future to avoid confusion. For author and date, git automatically changes the metadata when you commit after resolving conflicts, however I use '-x' option which adds "cherry picked from ..." line.

Benjamin, thanks for reporting and please keep testing the branch as we plan to release soon.
Comment 3 Alex Bikadorov 2019-07-07 18:33:24 UTC
*** Bug 409588 has been marked as a duplicate of this bug. ***