| Summary: | Kile crash when closing files | ||
|---|---|---|---|
| Product: | [Applications] kile | Reporter: | Johannes Hirte <johannes.hirte> |
| Component: | general | Assignee: | Michel Ludwig <michel.ludwig> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | kde |
| Priority: | NOR | ||
| Version First Reported In: | master | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Johannes Hirte
2019-07-03 07:09:55 UTC
the bad behaviour was introduced with this change in kguiaddons: commit 0fe2990dbad992a4925a7b7bee09b1cdfbe5a7a7 Author: Aleix Pol <aleixpol@kde.org> Date: Fri Jun 21 15:57:22 2019 +0200 Move to runtime the decision to use x11 or not Summary: Instead of deciding at build time which backend to use, see which is used upon construction. This will make it possible to have an alternative wayland implementation. Test Plan: See D20442 Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D20443 possible fix
diff --git a/src/eventfilter.cpp b/src/eventfilter.cpp
index 62dc724e..5ad1d514 100644
--- a/src/eventfilter.cpp
+++ b/src/eventfilter.cpp
@@ -32,7 +32,7 @@
LaTeXEventFilter::LaTeXEventFilter(KTextEditor::View *view, KileDocument::EditorExtension *edit) : QObject(view), m_view(view), m_edit(edit)
{
- m_modifierKeyInfo = new KModifierKeyInfo(this);
+ m_modifierKeyInfo = new KModifierKeyInfo(nullptr);
readConfig();
}
That patch will just leak the instance. A proper fix would be in KModifierKeyInfo. (In reply to Kai Uwe Broulik from comment #3) > That patch will just leak the instance. A proper fix would be in > KModifierKeyInfo. Yes, I've mixed something up when reading the code. fixed in kguiaddons with commit: commit 7ecff22e72158dd01492e1a7747b77e0d67acdad Author: Aleix Pol <aleixpol@kde.org> Date: Wed Jul 3 17:13:15 2019 +0200 KModifierKeyInfo: we are sharing the internal implementation Summary: Use data types that will only destroy it when necessary. Reviewers: broulik Subscribers: davidedmundson, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D22241 |