Bug 409166

Summary: skrooge appdata.xml missing release 2.20.0
Product: [Applications] skrooge Reporter: skierpage <info>
Component: generalAssignee: Guillaume DE BURE <guillaume.debure>
Status: RESOLVED FIXED    
Severity: normal CC: stephane
Priority: NOR    
Version First Reported In: Trunk from git   
Target Milestone: 25.1.0   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description skierpage 2019-06-25 10:16:01 UTC
SUMMARY
Skrooge 2.20 is on Flathub and works. However, https://flathub.org/apps/details/org.kde.skrooge shows its version as 2.19.0.

STEPS TO REPRODUCE
1. Visit Flathub, find the skrooge app
2. Install Skrooge from Flathub
3. flatpak run skrooge --version

OBSERVED RESULT
https://flathub.org/apps/details/org.kde.skrooge says skrooge is at version 2.19.0, but if you download and install it, it's actually at version 2.20.0.

EXPECTED RESULT
Flathub should show version 2.20.0.
I think Flathub gets the version from the first or most recent <release> tag within <releases> in skrooge/org.kde.skrooge.appdata.xml. So when making a release you have to update appdata.xml as well as CHANGELOG with the new release and date. (Then, once the KDE build has produced a source archive, someone has to make a pull request like  https://github.com/flathub/org.kde.skrooge/pull/8 to update Flathub's YAML build recipe with its URL and checksum; I'm happy to do that.)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: n/a

ADDITIONAL INFORMATION
I don't think this is critical to fix; people who install from Flathub will just get a newer Skrooge than indicated. But if it is, then you could make a 2.20.1 release.
BTW bugs.kde.org is missing a 2.20.0 Version select item for Skrooge.
Comment 1 Stephane MANKOWSKI 2019-06-25 21:24:30 UTC
Git commit 25b0094f01319b21acebbf7c064c5c802e089088 by Stephane MANKOWSKI.
Committed on 25/06/2019 at 21:24.
Pushed by smankowski into branch 'master'.
skrooge appdata.xml missing release 2.20.0

M  +5    -0    CHANGELOG
M  +1    -0    skrooge/org.kde.skrooge.appdata.xml

https://commits.kde.org/skrooge/25b0094f01319b21acebbf7c064c5c802e089088