Summary: | Eat Multiple Burst Notifications | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | vindicator <nroycea+kde> |
Component: | Notifications | Assignee: | Kai Uwe Broulik <kde> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, kdelibs-bugs, nate, plasma-bugs |
Priority: | NOR | ||
Version: | master | ||
Target Milestone: | 1.0 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/plasma-workspace/0ed653ba75d63de6e39125a3be00b72e5b32bab0 | Version Fixed In: | 5.16.3 |
Attachments: | Multiple Burst Notifications |
Description
vindicator
2019-06-25 03:34:22 UTC
I originally had it that it would combine multiple identical notifications but that can cause issues elsewhere. For example deleting two plasmoids of the same type in plasmashell will then only result in one notification. Maybe if they're done in quick succession (like within 1 second) we could refuse the notification request. That could make sense when the content is identical, yeah. BTW there are other canvas fingerprinting blocker extensions that don't send spammy notifications. Git commit 0ed653ba75d63de6e39125a3be00b72e5b32bab0 by Kai Uwe Broulik. Committed on 27/06/2019 at 10:06. Pushed by broulik into branch 'Plasma/5.16'. [Notifications] Ignore excess spam When multiple identical notifications are sent in quick succession, discard the request and let it fail. Previously it would always replace the last notification if identical, now it discards the request and only does so if it happened within 1 second of the last notification to avoid discarding genuine identical notifications like when deleting two plasmoids of the same type. FIXED-IN: 5.16.3 Differential Revision: https://phabricator.kde.org/D22088 M +18 -0 libnotificationmanager/server_p.cpp M +4 -2 libnotificationmanager/server_p.h https://commits.kde.org/plasma-workspace/0ed653ba75d63de6e39125a3be00b72e5b32bab0 |