Bug 409125

Summary: Observatory module
Product: [Applications] kstars Reporter: Jean-Claude <jcjesior>
Component: generalAssignee: Wolfgang Reissenberger <wreissen>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version First Reported In: 3.3.1   
Target Milestone: ---   
Platform: Other   
OS: macOS   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Jean-Claude 2019-06-24 12:18:21 UTC
SUMMARY
The Observatory module has been an awaited module.
Thank you Wolfgang.
I'm wondering if it would be possible to add 4 additional buttons which are found in the INDI Control Panel :
1/ a CW button and a CCW button to correct the dome aperture orientation as in the INDI Control Panel 
2/ an Home button
3/ a Slaving button




STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 10.14
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Wolfgang Reissenberger 2019-06-25 04:40:47 UTC
OK, I'll do my best.
Comment 2 Wolfgang Reissenberger 2019-06-25 09:01:07 UTC
The buttons for moving the dome and one for abort is more or less straight forward. But what functionality do you expect from the slaving button? 

For me it looks like it is OK when slaving is set up in the INDI configuration (as well as snoop devices etc). Or do you want to be able enabling and disabling slaving during runtime?
Comment 3 Jean-Claude 2019-06-25 09:18:45 UTC
I own a dome : This means that the scope must always match the dome aperture orientation.
The dome parameters can be set in the INDI Control Panel.
However after numerous trials I could not succeed to enter the right dome parameters which would align the scope and the dome aperture in all part of the sky.
This is why I need to correct sometime the dome position with the buttons CW and CCW.
But the dome being slaved, it doesn't like that and return immediately to the calculated position (which I don't want).
Thus if a correction is made with the buttons CW or CCW the dome must be unslaved.
Having all these buttons in the new Observatory module would allow to control the dome within EKOS without using the INDI Control panel.
Comment 4 Wolfgang Reissenberger 2019-07-02 18:29:11 UTC
Jean-Claude,
I need you help for testing, since I am not sure whether slaving is working appropriately. Could you please check out the branch observatory_work_motion from my kstars clone:
https://github.com/sterne-jaeger/kstars/tree/observatory_work_motion

I am testing with dome simulator and telescope simulator. When I turn on slaving, the dome moves to 270° - no matter where the scope is pointing to.
Comment 5 Jean-Claude 2019-07-02 18:55:46 UTC
Hi Wolfgang,
I'm sorry but I can't help you with code.
However if you live in Europe or a have compatible UTC, you could play with my whole setup through a TeamViewer session.
My private mail is jcjesior at free.fr
Comment 6 Jean-Claude 2019-07-02 19:27:24 UTC
Sorry, I misunderstood.
I tried KStars 331 with the scope simulator and the dome simulator.
I slew to several targets and the dome followed as expected.
Here is the INDI Control panel info :
2019-07-02T19:23:21: [INFO] Dome reached requested azimuth angle. 
2019-07-02T19:23:19: [INFO] Dome is syncing to position 137.647 degrees... 
2019-07-02T19:23:19: [INFO] Dome is moving to position 137.647 degrees... 
2019-07-02T19:22:59: [INFO] Dome reached requested azimuth angle. 
2019-07-02T19:22:44: [INFO] Dome is syncing to position 173.043 degrees... 
2019-07-02T19:22:44: [INFO] Dome is moving to position 173.043 degrees... 
2019-07-02T19:22:19: [INFO] Dome reached requested azimuth angle. 
2019-07-02T19:22:18: [INFO] Dome is syncing to position 340.718 degrees... 
2019-07-02T19:22:18: [INFO] Dome is moving to position 340.718 degrees... 
2019-07-02T19:21:54: [INFO] Dome synced to position 319.961 degrees. 
2019-07-02T19:21:54: [INFO] Dome moved to position 319.961 degrees. 
2019-07-02T19:21:48: [INFO] Dome reached requested azimuth angle. 
2019-07-02T19:21:20: [INFO] Dome is syncing to position 325.406 degrees... 
2019-07-02T19:21:20: [INFO] Dome is moving to position 325.406 degrees... 
2019-07-02T19:21:10: [INFO] Dome reached requested azimuth angle. 
2019-07-02T19:20:39: [INFO] Dome is syncing to position 29.9402 degrees... 
2019-07-02T19:20:39: [INFO] Dome is moving to position 29.9402 degrees... 
2019-07-02T19:20:39: [INFO] Dome reached requested azimuth angle. 
2019-07-02T19:20:35: [INFO] Dome already unparked. 
2019-07-02T19:20:05: [INFO] Device configuration applied. 
2019-07-02T19:20:05: [INFO] Dome is syncing to position 344.32 degrees... 
2019-07-02T19:20:05: [INFO] Dome is moving to position 344.32 degrees... 
2019-07-02T19:20:05: [INFO] Auto park is disabled. 
2019-07-02T19:20:05: [INFO] Auto search is enabled. When connecting, the driver shall attempt to communicate with all available system ports until a connection is established. 
2019-07-02T19:20:05: [INFO] Auto search is enabled. When connecting, the driver shall attempt to communicate with all available system ports until a connection is established. 
2019-07-02T19:20:05: [INFO] Loading device configuration... 
2019-07-02T19:20:04: [INFO] Dome is unparked. 
2019-07-02T19:20:03: [INFO] Auto search is enabled. When connecting, the driver shall attempt to communicate with all available system ports until a connection is established.
Comment 7 Jean-Claude 2019-07-02 19:54:30 UTC
I understand what happened : you didn't set the Measurements in the Slaving tab !
If all parameters are = 0, this will result in :
2019-07-02T19:39:29: [INFO] Dome reached requested azimuth angle. 
2019-07-02T19:39:22: [INFO] Dome is syncing to position 270 degrees... 
2019-07-02T19:39:22: [INFO] Dome is moving to position 270 degrees... 
2019-07-02T19:39:22: [INFO] Dome reached requested azimuth angle. 
2019-07-02T19:38:48: [INFO] Device configuration applied. 

Please try my measurements :
• Dome geometry (KStars)
- Autosync threshold (deg.) = 0.50°
- Radius (m) = 1.150 m
- Shutter width (m) = 0.600 m
- N displacement (m) = 0.120 m
- E displacement (m) = 0.100 m
- Up displacement (m) = -0.217 m
- OTA offset (m) = 0.405 m
With the dome simulator you will not need to set :
- Home + Park azimuth = 73.00°
- Ticks per turn = 357

Please tell me if it helped.
Comment 8 Wolfgang Reissenberger 2019-07-02 20:26:35 UTC
Ah, I found the problem. In my simulator setup, I had dome radius etc. all set to 0. When I set the dome radius to 5m, it's working fine.

OK, should be ready for testing. I posted a new diff:
https://phabricator.kde.org/D22224
Comment 9 Jean-Claude 2019-07-03 07:24:15 UTC
As I wrote earlier I'm not competent to test the code but if you want to test it on my equipment you're welcome.
Comment 10 Wolfgang Reissenberger 2019-07-03 11:26:51 UTC
Should be in one of the nexts nightly builds.