Bug 409082

Summary:	Icon request: View layout icons for Okular: Single Page, Facing Pages, Facing Pages (First Page Centered), Overview
Product:	[Plasma] Breeze	Reporter:	Laura David Hurka <laura.stern>
Component:	Icons	Assignee:	visual-bugs-null
Status:	RESOLVED FIXED
Severity:	normal	CC:	kainz.a, nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Unspecified
Latest Commit:	https://commits.kde.org/breeze-icons/7069d6f0cb3d5278f9de31c7d68976e711e859c2	Version Fixed/Implemented In:	5.61
Sentry Crash Report:
Attachments:	Suggestion for page layout icons

Description Laura David Hurka 2019-06-23 15:10:20 UTC

Created attachment 121096 [details]
Suggestion for page layout icons

Okular allows to change the page layout in the View -> View Mode menu.
The view modes are:
 - Single Page,
 - Facing Pages,
 - Facing Pages (First Page Centered),
 - Overview

I have attached a mockup as suggestion for the icons,
see also https://phabricator.kde.org/D21196

The Single Page icon looks like tool_pagelayout or snap-page.

“tool_pagelayout” probably had a pushbutton “Configure Page Layout...” in mind.

Suggestion for the icon names:
pagelayout-single
pagelayout-facing
pagelayout-facing-first-centered
pagelayout-overview

Overview IMHO shouldn’t have 3 pages in a horizontal row, because the column count is configurable. 3 is only the default. That’s why I arranged the pages like in the save-all icon.

Continuous currently uses view-list-text, IMHO it should be like insert-page-break, but without dashed line and with lower and upper halves swapped, so two pages are partially visible.
Name: pagelayout-continuous

Comment 1 Nate Graham 2019-07-26 14:13:31 UTC

Git commit 7069d6f0cb3d5278f9de31c7d68976e711e859c2 by Nate Graham, on behalf of David Hurka.
Committed on 26/07/2019 at 14:13.
Pushed by ngraham into branch 'master'.

Add view-pages-* icons, as needed in Okular for page layout selection

Summary:
This is my try to add the icons I requested in D21196#484674.

The icons are: view-pages-[single|facing|facing-first-centered|overview], as they are needed for the View Layout menu; and view-pages-continuous, as it is needed for the Continuous view option (which might be moved into the View Layout menu).

view-pages-single is a symlink to snap-page, because it’s the same icon.

Additionally, snap-pages is flipped vertically, to fit the new convention with the paper fold in the top right corner.

Test Plan:
{F7077807}
{F7077811}

Reviewers: #vdg, ndavis, ngraham

Reviewed By: #vdg, ndavis, ngraham

Subscribers: #okular, kde-frameworks-devel, ngraham

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22617

M  +7    -11   icons-dark/actions/16/snap-page.svg
A  +10   -0    icons-dark/actions/16/view-pages-continuous.svg
A  +7    -0    icons-dark/actions/16/view-pages-facing-first-centered.svg
A  +9    -0    icons-dark/actions/16/view-pages-facing.svg
A  +9    -0    icons-dark/actions/16/view-pages-overview.svg
A  +1    -0    icons-dark/actions/16/view-pages-single.svg
M  +7    -12   icons-dark/actions/22/snap-page.svg
A  +10   -0    icons-dark/actions/22/view-pages-continuous.svg
A  +7    -0    icons-dark/actions/22/view-pages-facing-first-centered.svg
A  +10   -0    icons-dark/actions/22/view-pages-facing.svg
A  +9    -0    icons-dark/actions/22/view-pages-overview.svg
A  +1    -0    icons-dark/actions/22/view-pages-single.svg
M  +7    -11   icons-dark/actions/24/snap-page.svg
M  +7    -11   icons/actions/16/snap-page.svg
A  +10   -0    icons/actions/16/view-pages-continuous.svg
A  +7    -0    icons/actions/16/view-pages-facing-first-centered.svg
A  +9    -0    icons/actions/16/view-pages-facing.svg
A  +9    -0    icons/actions/16/view-pages-overview.svg
A  +1    -0    icons/actions/16/view-pages-single.svg
M  +7    -12   icons/actions/22/snap-page.svg
A  +10   -0    icons/actions/22/view-pages-continuous.svg
A  +7    -0    icons/actions/22/view-pages-facing-first-centered.svg
A  +10   -0    icons/actions/22/view-pages-facing.svg
A  +9    -0    icons/actions/22/view-pages-overview.svg
A  +1    -0    icons/actions/22/view-pages-single.svg
M  +7    -11   icons/actions/24/snap-page.svg

https://commits.kde.org/breeze-icons/7069d6f0cb3d5278f9de31c7d68976e711e859c2