Bug 409045

Summary:	Handle QtWebEngine notifications
Product:	[Applications] Falkon	Reporter:	Juraj <jurajoravec>
Component:	general	Assignee:	David Rosca <nowrep>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	3.1.0
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://commits.kde.org/falkon/2a0f0924362aa87a95d155f98816c3d9ae54e1a9	Version Fixed/Implemented In:
Sentry Crash Report:

Description Juraj 2019-06-22 17:03:39 UTC

SUMMARY
Since QtWebEngine 5.13 threse is support for web notifications.
These notifications does notn follow the Falkon settings (Preferences > Notificsations)

STEPS TO REPRODUCE
1. Go tosome site which can display notifications
https://web-push-book.gauntface.com/demos/notification-examples/
2. Allow notifications
3. Make the site display some notifications

OBSERVED RESULT
Falkon shows notification is Windows XP style with light yellow bubble and tray icon.

EXPECTED RESULT
Notifications settings set in Falkon Preferences dialog.

SOFTWARE/OS VERSIONS
Operating System: Artix Linux 
KDE Plasma Version: 5.16.1
KDE Frameworks Version: 5.59.0
Qt Version: 5.13.0
Kernel Version: 4.19.52-1-lts
OS Type: 64-bit
Application version 3.1.0
QtWebEngine version 5.13.0

Comment 1 Juraj 2020-01-20 19:40:15 UTC

Git commit 2a0f0924362aa87a95d155f98816c3d9ae54e1a9 by Juraj Oravec.
Committed on 20/01/2020 at 19:39.
Pushed by jurajo into branch 'master'.

Handle web push notifications with Falkon notification system

Summary:
Add basic support for web notifications with icon, title and body text.

Test Plan: Fire some notifications from webpage

Reviewers: #falkon

Subscribers: falkon

Tags: #falkon

Differential Revision: https://phabricator.kde.org/D26452

M  +14   -0    src/lib/app/mainapplication.cpp

https://commits.kde.org/falkon/2a0f0924362aa87a95d155f98816c3d9ae54e1a9