Bug 409044

Summary:	export options reset each time
Product:	[Applications] krita	Reporter:	fsqrt <fsqrt>
Component:	General	Assignee:	vanyossi <ghevan>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ghevan, halla
Priority:	NOR	Keywords:	regression
Version:	4.2.1
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:	https://invent.kde.org/kde/krita/commit/5ac8bc3e1df368ff9f99fca3408469b4fdef69b8	Version Fixed In:
Sentry Crash Report:

Description fsqrt 2019-06-22 16:24:01 UTC

Export Options dialog reset their states of checkbox/slider each time a file is exported.

STEPS TO REPRODUCE:
1. click File->Export from main menu
2. enter file name (.jpg or .png) and click save button
3. change export options on dialog and click ok
4. repeat 1 and 2 again

OBSERVED RESULT:
export options reset to their default state.

EXPECTED RESULT:
keep previously changed export options.

ADDITIONAL INFORMATION:
4.1.7 works as expected.

Comment 1 Halla Rempt 2019-06-22 16:54:50 UTC

I checked this today, and it's indeed a confirmed regression. I needed to restart Krita to reproduce it, though.

Comment 2 vanyossi 2019-11-13 09:28:35 UTC

Git commit 434c85828b3bd20a4e6348d0fbd5768dca516a47 by Ivan Yossi.
Committed on 13/11/2019 at 06:31.
Pushed by rempt into branch 'master'.

Allow export dialog preferences to be saved

showWarnings is by default always set to false which
made the exportConfiguration to never be saved. Removing
that condition does not seem to affect 5a6aa50626 on export
or animation export.

M  +1    -1    libs/ui/KisImportExportManager.cpp

https://invent.kde.org/kde/krita/commit/434c85828b3bd20a4e6348d0fbd5768dca516a47

Comment 3 Halla Rempt 2019-11-15 10:36:12 UTC

Git commit 5ac8bc3e1df368ff9f99fca3408469b4fdef69b8 by Boudewijn Rempt, on behalf of Ivan Yossi.
Committed on 15/11/2019 at 10:10.
Pushed by rempt into branch 'krita/4.2'.

Allow export dialog preferences to be saved

showWarnings is by default always set to false which
made the exportConfiguration to never be saved. Removing
that condition does not seem to affect 5a6aa50626 on export
or animation export.
(cherry picked from commit 434c85828b3bd20a4e6348d0fbd5768dca516a47)

M  +1    -1    libs/ui/KisImportExportManager.cpp

https://invent.kde.org/kde/krita/commit/5ac8bc3e1df368ff9f99fca3408469b4fdef69b8