Bug 409015

Summary: Splash Screen themes are not set properly when applying Look & Feels
Product: [Applications] systemsettings Reporter: The Feren OS Dev <ferenosdev>
Component: kcm_lookandfeelAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: nate, notmart
Priority: NOR    
Version: 5.16.1   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/commit/34e2541b64c05501530655090298ac6f95273063 Version Fixed In: 5.25
Sentry Crash Report:

Description The Feren OS Dev 2019-06-21 22:24:28 UTC 
SUMMARY
So, basically with a Look & Feel that has the following under its 'defaults' file, I've noticed odd behaviour with the changing of Splash Screens during this process. Mainly that the Look & Feel switcher seems to ignore the fact that the 'defaults' file has asked that a certain splash screen be set and instead sets the splash screen to be the name of the Look & Feel applied.
e.g.: Got a theme named 'org.feren.dark', with the below contents in its 'details' file? It sets the splash screen to 'org.feren.dark' instead of 'org.feren.default':
Setting in 'details' file:
[ksplashrc][KSplash]
Theme=org.feren.default

STEPS TO REPRODUCE
1. Make a Look & Feel that should in theory set the Splash Screen to a splash screen that is part of another Look & Feel instead of itself
2. Apply the Look & Feel

OBSERVED RESULT
In ksplashrc, the setting can be observed to have changed to what the Look & Feel's folder name is, rather than the requested Splash Screen theme name

EXPECTED RESULT
The requested Splash Screen theme would be set during Look & Feel application

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: KDE neon 5.16.1
(available in About System)
KDE Plasma Version: 5.16.1
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.3

ADDITIONAL INFORMATION
N/A
Comment 1 The Feren OS Dev 2019-06-21 22:26:35 UTC 
*So, basically with the application of a Look & Feel that has the something along the lines of what is shown below inside of its 'defaults' file, I've noticed odd behaviour with the changing of the current Splash Screen in use during the Look & Feel application process.
Comment 2 Nate Graham 2022-04-19 15:24:19 UTC 
Git commit 34e2541b64c05501530655090298ac6f95273063 by Nate Graham, on behalf of Dominic Hayes.
Committed on 19/04/2022 at 15:24.
Pushed by ngraham into branch 'master'.

kcms/lookandfeel: allow users to choose what part of a Global Theme to apply

Now when you click on a Global Theme, it will display a Kirigami sheet for
choosing what is applied. The user can choose individual appearance elements,
and apply the theme's desktop layout, or not.
Related: bug 437037
FIXED-IN: 5.25

M  +116  -18   kcms/lookandfeel/kcm.cpp
M  +19   -4    kcms/lookandfeel/kcm.h
M  +7    -1    kcms/lookandfeel/lnftool.cpp
M  +132  -112  kcms/lookandfeel/lookandfeelmanager.cpp
M  +41   -21   kcms/lookandfeel/lookandfeelmanager.h
A  +82   -0    kcms/lookandfeel/package/contents/ui/MoreOptions.qml     [License: LGPL(v2.0)]
A  +91   -0    kcms/lookandfeel/package/contents/ui/SimpleOptions.qml     [License: LGPL(v2.0)]
M  +98   -40   kcms/lookandfeel/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/34e2541b64c05501530655090298ac6f95273063