| Summary: | widgets/actionbutton isn't used anymore | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Antonio Orefice <kokoko3k> |
| Component: | Notifications | Assignee: | Kai Uwe Broulik <kde> |
| Status: | RESOLVED DOWNSTREAM | ||
| Severity: | normal | CC: | nate, plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | 5.16.1 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
notification that shows the problem
How they used to be (just a quick and poorly done mockup, sorry) original notification from 5.15 |
||
Operating System: Arch Linux KDE Plasma Version: 5.16.0 KDE Frameworks Version: 5.59.0 Qt Version: 5.12.3 Kernel Version: 5.1.9-arch1-1-ARCH OS Type: 64-bit Processors: 4 × Intel® Core™ i5-4590 CPU @ 3.30GHz Memory: 15,7 GiB of RAM Created attachment 121055 [details]
How they used to be (just a quick and poorly done mockup, sorry)
I did a mockup to better explain the problem
The previous icon was a ToolButton just like it is now. Except previously it wasn't flat (and then magically turned round) but now is. This is by design. Are you 100% sure? ISorry if i'm asking, but i'm using an home made theme and my icon was just a black "X", and i'm pretty sure it was surrounded by frames from window.svgz; that's why i posted. I also clearly remember seeing it "glowing" (the circle becomes surrounded by a blue halo), when the mouse pointer hovered it. All that indicates the use of elements from window.svg. Ok, i just installed 5.15.5 and can confirm that in the previous version the X "magically turned round". If i understood you properly, you stated: 1) it was intentional 2) actionbutton.svg wasn't even used int the past (which is wrong). But for developing my theme (which is on store.kde.org), i still need to know if somebody forgot to use actionbutton.svg or it is in the plans to NOT not use it in the future anymore. If the latter, i'll just overlay widgets/actionbuttons.svg into icons/window.svg (and loose the glow, which is not nice, but better than nothing). Thanks Created attachment 121059 [details]
original notification from 5.15
As you can see, the frame around the "X" reacts to hover and mousedown events.
it can't be a single picture.
From what I can tell actionbuttons is mostly used on the desktop (applet handle and the selection buttons for files), not really in any applets. The new flat button also reacts to hover by painting a frame. It seems now it uses widgets/button.svg instead. Is it intended? This is a problem with your icon theme. Monochrome icons are supposed to change their colors appropriately depending on the active color theme so they can avoid just this problem. Looks like that "x" icon in your icon theme isn't doing that, so it stays black when it's against a dark background instead of turning white. To see how to do this, please read https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Embedding_stylesheets_in_SVGs and https://hig.kde.org/style/icon.html |
Created attachment 121053 [details] notification that shows the problem SUMMARY In previous plasmashell versions, the close notification symbol was surrounded by an icon taken from widgets/actionbutton.svg(z) This is no more, it just picks the icon from icons/window.svg(z) and displays it. This leads to problems if the close icon uses a color that blends into the widget background (see attached files) STEPS TO REPRODUCE 1. Use a dark theme that provides a colored "window close icon" frol icons/window.svg(z) 2. display a notification OBSERVED RESULT Note that no frame from widgets/actionbutton.svg(z) is used EXPECTED RESULT A frame from widgets/actionbutton.svg(z) is used SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION