Summary: | disallow duplicate bookmarks | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Teemu Rytilahti <tpr> |
Component: | bookmark | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | hacker.yoddha, nate, tcanabrava |
Priority: | NOR | Keywords: | junior-jobs, usability |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/konsole/befaaa0255b2e620753a6a119268515d4b0b8413 | Version Fixed In: | 19.12 |
Description
Teemu Rytilahti
2019-06-20 05:02:12 UTC
Heh, I also have a ton of duplicate bookmarks. Git commit befaaa0255b2e620753a6a119268515d4b0b8413 by Kurt Hindenburg, on behalf of Martin T. H. Sandsmark. Committed on 24/08/2019 at 19:12. Pushed by hindenburg into branch 'master'. Do not allow adding duplicates in bookmarks This currently only catches bookmarks in top-level (ie not sub-folders) Original code by Tomaz Canabrava <tcanabrava@kde.org> FIXED-IN: 19.12 https://invent.kde.org/kde/konsole/merge_requests/8 M +4 -5 src/BookmarkHandler.cpp M +0 -2 src/BookmarkHandler.h A +54 -0 src/BookmarkMenu.cpp [License: LGPL] A +48 -0 src/BookmarkMenu.h [License: LGPL] M +1 -0 src/CMakeLists.txt https://invent.kde.org/kde/konsole/commit/befaaa0255b2e620753a6a119268515d4b0b8413 Git commit befaaa0255b2e620753a6a119268515d4b0b8413 by Kurt Hindenburg, on behalf of Martin T. H. Sandsmark. Committed on 24/08/2019 at 19:12. Pushed by scmsync into branch 'master'. Do not allow adding duplicates in bookmarks This currently only catches bookmarks in top-level (ie not sub-folders) Original code by Tomaz Canabrava <tcanabrava@kde.org> FIXED-IN: 19.12 https://invent.kde.org/kde/konsole/merge_requests/8 M +4 -5 src/BookmarkHandler.cpp M +0 -2 src/BookmarkHandler.h A +54 -0 src/BookmarkMenu.cpp [License: LGPL] A +48 -0 src/BookmarkMenu.h [License: LGPL] M +1 -0 src/CMakeLists.txt https://commits.kde.org/konsole/befaaa0255b2e620753a6a119268515d4b0b8413 Do you think Konsole should try to add a menu option to "Remove duplicate bookmarks"? Maybe it should just auto-remove them in the next release. Thanks a lot for such a quick turnaround! (In reply to Kurt Hindenburg from comment #5) > Do you think Konsole should try to add a menu option to "Remove duplicate > bookmarks"? I don't think it's necessary to add more code that needs to be maintained. In case such feature is wanted, I think a better way would be to extend the DBUS interface of KBookmarkManager to allow removal of bookmarks. Then it would be fairly simple to create a script to do that (as I suppose removal of existing duplicates will be more or less a single shot procedure anyway). |