Bug 408752

Summary: Comma separator in stored constant returns nan
Product: [Applications] kcalc Reporter: Dan <danretired42>
Component: generalAssignee: Gabriel Barrantes <gabriel.barrantes.dev>
Status: CONFIRMED ---    
Severity: normal CC: futureth232, gabriel.barrantes.dev, joewinzer
Priority: NOR    
Version First Reported In: 18.12   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=488167
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Dan 2019-06-15 19:51:47 UTC 
SUMMARY
Comma separator in stored constant returns nan

STEPS TO REPRODUCE
1. In Settings select Science Mode
2. In Settings turn on Constants Buttons
3. With a number greater than one thousand in the display field (with comma separators) select the Shift button. The C1-C6 buttons will all change to Store
4. Select one of the Store buttons
5. Clear the display with AC button
6. Hover over the button the number was stored in (C1-C6). The stored number  should be displayed as a tool tip
7. Select the button the number was stored in

OBSERVED RESULT
The display field shows nan

EXPECTED RESULT
The stored number

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:
KDE Plasma Version: 5.15.5
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.1

ADDITIONAL INFORMATION
In Settings if you select Configure Kcalc...
you can edit the entry to remove the commas and it will work.
Comment 1 Christoph Feck 2019-07-03 13:00:32 UTC 
Confirmed also in current master version.
Comment 2 Joseph-Eugene Winzer 2019-07-04 15:16:37 UTC 
Submitted a fix to https://phabricator.kde.org/D22263
Comment 3 Christoph Feck 2019-07-05 01:55:58 UTC 
Oh, I already posted https://phabricator.kde.org/D22239 yesterday...

Please set the reviewers, and let them decide which approach is better.
Comment 4 Joseph-Eugene Winzer 2019-07-05 13:42:02 UTC 
(In reply to Christoph Feck from comment #3)
> Oh, I already posted https://phabricator.kde.org/D22239 yesterday...
> 
> Please set the reviewers, and let them decide which approach is better.

I'm sorry. I tried to look if there's a patch for it already but I'm not really familiar with the Phabricator interface so I must have missed it :/

I set the same reviewers as you did now. Thanks for the info.